Skip to content

Commit

Permalink
time: Move timeconst.h into include/generated
Browse files Browse the repository at this point in the history
kernel/time/timeconst.h is moved to include/generated/ and generated 
by the top level Kbuild. This allows using timeconst.h in an earlier
build stage.

Signed-off-by: Nicholas Mc Guire <[email protected]>
Cc: Masahiro Yamada <[email protected]>
Cc: Sam Ravnborg <[email protected]>
Cc: Joe Perches <[email protected]>
Cc: John Stultz <[email protected]>
Cc: Andrew Hunter <[email protected]>
Cc: Paul Turner <[email protected]>
Cc: Michal Marek <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Thomas Gleixner <[email protected]>
  • Loading branch information
Nicholas Mc Guire authored and KAGA-KOKO committed May 19, 2015
1 parent 4cfafd3 commit 0a22798
Show file tree
Hide file tree
Showing 4 changed files with 31 additions and 25 deletions.
34 changes: 27 additions & 7 deletions Kbuild
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
# Kbuild for top-level directory of the kernel
# This file takes care of the following:
# 1) Generate bounds.h
# 2) Generate asm-offsets.h (may need bounds.h)
# 3) Check for missing system calls
# 2) Generate timeconst.h
# 3) Generate asm-offsets.h (may need bounds.h and timeconst.h)
# 4) Check for missing system calls

# Default sed regexp - multiline due to syntax constraints
define sed-y
Expand Down Expand Up @@ -47,7 +48,26 @@ $(obj)/$(bounds-file): kernel/bounds.s FORCE
$(call filechk,offsets,__LINUX_BOUNDS_H__)

#####
# 2) Generate asm-offsets.h
# 2) Generate timeconst.h

timeconst-file := include/generated/timeconst.h

#always += $(timeconst-file)
targets += $(timeconst-file)

quiet_cmd_gentimeconst = GEN $@
define cmd_gentimeconst
(echo $(CONFIG_HZ) | bc -q $< ) > $@
endef
define filechk_gentimeconst
(echo $(CONFIG_HZ) | bc -q $< )
endef

$(obj)/$(timeconst-file): kernel/time/timeconst.bc FORCE
$(call filechk,gentimeconst)

#####
# 3) Generate asm-offsets.h
#

offsets-file := include/generated/asm-offsets.h
Expand All @@ -57,15 +77,15 @@ targets += arch/$(SRCARCH)/kernel/asm-offsets.s

# We use internal kbuild rules to avoid the "is up to date" message from make
arch/$(SRCARCH)/kernel/asm-offsets.s: arch/$(SRCARCH)/kernel/asm-offsets.c \
$(obj)/$(bounds-file) FORCE
$(obj)/$(timeconst-file) $(obj)/$(bounds-file) FORCE
$(Q)mkdir -p $(dir $@)
$(call if_changed_dep,cc_s_c)

$(obj)/$(offsets-file): arch/$(SRCARCH)/kernel/asm-offsets.s FORCE
$(call filechk,offsets,__ASM_OFFSETS_H__)

#####
# 3) Check for missing system calls
# 4) Check for missing system calls
#

always += missing-syscalls
Expand All @@ -77,5 +97,5 @@ quiet_cmd_syscalls = CALL $<
missing-syscalls: scripts/checksyscalls.sh $(offsets-file) FORCE
$(call cmd,syscalls)

# Keep these two files during make clean
no-clean-files := $(bounds-file) $(offsets-file)
# Keep these three files during make clean
no-clean-files := $(bounds-file) $(offsets-file) $(timeconst-file)
17 changes: 1 addition & 16 deletions kernel/time/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -13,19 +13,4 @@ obj-$(CONFIG_TIMER_STATS) += timer_stats.o
obj-$(CONFIG_DEBUG_FS) += timekeeping_debug.o
obj-$(CONFIG_TEST_UDELAY) += test_udelay.o

$(obj)/time.o: $(obj)/timeconst.h

quiet_cmd_hzfile = HZFILE $@
cmd_hzfile = echo "hz=$(CONFIG_HZ)" > $@

targets += hz.bc
$(obj)/hz.bc: $(objtree)/include/config/hz.h FORCE
$(call if_changed,hzfile)

quiet_cmd_bc = BC $@
cmd_bc = bc -q $(filter-out FORCE,$^) > $@

targets += timeconst.h
$(obj)/timeconst.h: $(obj)/hz.bc $(src)/timeconst.bc FORCE
$(call if_changed,bc)

$(obj)/time.o: $(objtree)/include/config/
2 changes: 1 addition & 1 deletion kernel/time/time.c
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
#include <asm/uaccess.h>
#include <asm/unistd.h>

#include "timeconst.h"
#include <generated/timeconst.h>
#include "timekeeping.h"

/*
Expand Down
3 changes: 2 additions & 1 deletion kernel/time/timeconst.bc
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ define timeconst(hz) {
print "#include <linux/types.h>\n\n"

print "#if HZ != ", hz, "\n"
print "#error \qkernel/timeconst.h has the wrong HZ value!\q\n"
print "#error \qinclude/generated/timeconst.h has the wrong HZ value!\q\n"
print "#endif\n\n"

if (hz < 2) {
Expand Down Expand Up @@ -105,4 +105,5 @@ define timeconst(hz) {
halt
}

hz = read();
timeconst(hz)

0 comments on commit 0a22798

Please sign in to comment.