Skip to content

Commit

Permalink
eisa/pci_eisa.c: fix BUG introduced by 005bdad
Browse files Browse the repository at this point in the history
While `pci_eisa_driver' still refer `pci_eisa_init', the .probe() function
should not be called after init memory release, as pointed out by commit
74b9a29. The structure is still referenced in the drivers subsystem, and can
be accesseed through sysfs, so the modpost warning is a false positive. Mark
it as such.

In the same time, the warning referenced in 005bdad did only mention
`pci_eisa_driver', not `pci_eisa_pci_tbl', so remove its marking.

Broken-by: Arnaud Lacombe <[email protected]> (in 005bdad)
Reported-by: Tetsuo Handa <[email protected]>
Signed-off-by: Arnaud Lacombe <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
lacombar authored and torvalds committed Aug 4, 2011
1 parent 288d5ab commit 82de9a0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/eisa/pci_eisa.c
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,13 @@ static int __init pci_eisa_init(struct pci_dev *pdev,
return 0;
}

static struct pci_device_id __initdata pci_eisa_pci_tbl[] = {
static struct pci_device_id pci_eisa_pci_tbl[] = {
{ PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,
PCI_CLASS_BRIDGE_EISA << 8, 0xffff00, 0 },
{ 0, }
};

static struct pci_driver __initdata pci_eisa_driver = {
static struct pci_driver __refdata pci_eisa_driver = {
.name = "pci_eisa",
.id_table = pci_eisa_pci_tbl,
.probe = pci_eisa_init,
Expand Down

0 comments on commit 82de9a0

Please sign in to comment.