Fix bench driver panic (MystenLabs#7014)

cardinality needs to be consistent
artifactstaking · Dec 23, 2022 · e425af0 · e425af0
1 parent 7d0f25b
commit e425af0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/crates/sui-benchmark/src/drivers/bench_driver.rs b/crates/sui-benchmark/src/drivers/bench_driver.rs
@@ -51,7 +51,7 @@ const LATENCY_SEC_BUCKETS: &[f64] = &[
     0.01, 0.05, 0.1, 0.25, 0.5, 1., 2.5, 5., 10., 20., 30., 60., 90.,
 ];
 
-const RECONFIG_QUIESCENCE_TIME_SEC: u64 = 10;
+const RECONFIG_QUIESCENCE_TIME_SEC: u64 = 5;
 
 impl BenchMetrics {
     fn new(registry: &Registry) -> Self {
@@ -413,7 +413,7 @@ impl Driver<BenchmarkStats> for BenchDriver {
                                                 proxy_clone.reconfig().await;
                                             } else {
                                                 error!("Retry due to error: {}", err);
-                                                metrics_cloned.num_error.with_label_values(&[&payload.get_workload_type().to_string(), err.as_ref()]).inc();
+                                                metrics_cloned.num_error.with_label_values(&[&payload.get_workload_type().to_string()]).inc();
                                             }
                                             NextOp::Retry(Box::new((tx, payload)))
                                         }

diff --git a/crates/sui-types/src/error.rs b/crates/sui-types/src/error.rs
@@ -606,10 +606,7 @@ impl SuiError {
         match self {
             SuiError::QuorumFailedToProcessTransaction { errors, .. }
             | SuiError::QuorumFailedToExecuteCertificate { errors, .. } => {
-                errors.iter().any(|err| {
-                    matches!(err, SuiError::ValidatorHaltedAtEpochEnd)
-                        || matches!(self, SuiError::MissingCommitteeAtEpoch(_))
-                })
+                errors.iter().any(|err| err.indicates_epoch_change())
             }
             SuiError::ValidatorHaltedAtEpochEnd | SuiError::MissingCommitteeAtEpoch(_) => true,
             _ => false,