fix: set antialiasing as flag in node bindings (dmtrKovalenko#45)

arunbanswal · Jun 28, 2021 · f73034c · f73034c
1 parent c438b31
commit f73034c
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/bin/node-bindings/odiff.js b/bin/node-bindings/odiff.js
@@ -43,7 +43,7 @@ function optionsToArgs(options) {
         break;
 
       case "antialiasing":
-        setArgWithValue("antialiasing", value);
+        setFlag("antialiasing", value);
         break;
 
       case "ignoreRegions": {

diff --git a/test/node-binding.test.cjs b/test/node-binding.test.cjs
@@ -31,7 +31,7 @@ test("Outputs correct parsed result when images different", async (t) => {
   t.is(diffPercentage, 2.85952484323);
 });
 
-test("Correctly parses cli arguments", async (t) => {
+test("Correctly parses threshold", async (t) => {
   const { reason, diffCount, diffPercentage } = await compare(
     path.join(IMAGES_PATH, "donkey.png"),
     path.join(IMAGES_PATH, "donkey-2.png"),
@@ -47,6 +47,22 @@ test("Correctly parses cli arguments", async (t) => {
   t.is(diffPercentage, 1.31007003768);
 });
 
+test("Correctly parses antialiasing", async (t) => {
+  const { reason, diffCount, diffPercentage } = await compare(
+    path.join(IMAGES_PATH, "donkey.png"),
+    path.join(IMAGES_PATH, "donkey-2.png"),
+    path.join(IMAGES_PATH, "diff.png"),
+    {
+      antialiasing: true,
+      __binaryPath: BINARY_PATH,
+    }
+  )
+
+  t.is(reason, 'pixel-diff')
+  t.is(diffCount, 108208);
+  t.is(diffPercentage, 2.8164996153);
+});
+
 test("Correctly parses ignore regions", async (t) => {
   const { match } = await compare(
     path.join(IMAGES_PATH, "donkey.png"),