Skip to content

Commit

Permalink
tools/usb: remove last USBFS user
Browse files Browse the repository at this point in the history
In commit fb28d58 ("USB: remove CONFIG_USB_DEVICEFS") USBFS got
removed. Since it is gone we can stop using it in testusb and try udev
nodes right away.

Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
Sebastian Andrzej Siewior authored and gregkh committed Sep 10, 2012
1 parent 0837e7e commit 8a424bf
Showing 1 changed file with 1 addition and 24 deletions.
25 changes: 1 addition & 24 deletions tools/usb/testusb.c
Original file line number Diff line number Diff line change
Expand Up @@ -253,9 +253,6 @@ static int find_testdev(const char *name, const struct stat *sb, int flag)

if (flag != FTW_F)
return 0;
/* ignore /proc/bus/usb/{devices,drivers} */
if (strrchr(name, '/')[1] == 'd')
return 0;

fd = fopen(name, "rb");
if (!fd) {
Expand Down Expand Up @@ -356,28 +353,8 @@ static void *handle_testdev (void *arg)

static const char *usbfs_dir_find(void)
{
static char usbfs_path_0[] = "/dev/usb/devices";
static char usbfs_path_1[] = "/proc/bus/usb/devices";
static char udev_usb_path[] = "/dev/bus/usb";

static char *const usbfs_paths[] = {
usbfs_path_0, usbfs_path_1
};

static char *const *
end = usbfs_paths + sizeof usbfs_paths / sizeof *usbfs_paths;

char *const *it = usbfs_paths;
do {
int fd = open(*it, O_RDONLY);
close(fd);
if (fd >= 0) {
strrchr(*it, '/')[0] = '\0';
return *it;
}
} while (++it != end);

/* real device-nodes managed by udev */
if (access(udev_usb_path, F_OK) == 0)
return udev_usb_path;

Expand Down Expand Up @@ -489,7 +466,7 @@ int main (int argc, char **argv)
goto usage;
if (!all && !device) {
fprintf (stderr, "must specify '-a' or '-D dev', "
"or DEVICE=/proc/bus/usb/BBB/DDD in env\n");
"or DEVICE=/dev/bus/usb/BBB/DDD in env\n");
goto usage;
}

Expand Down

0 comments on commit 8a424bf

Please sign in to comment.