fix: application crash by wrong / missing secret key

The middleware tries to end the request several times. If the authorization fails the code will be executed anyway
asdlei99 · Jun 20, 2021 · 7a2dc21 · 7a2dc21
1 parent 05e512d
commit 7a2dc21
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/server/src/shared/infra/http/utils/Middleware.ts b/server/src/shared/infra/http/utils/Middleware.ts
@@ -20,12 +20,12 @@ export class Middleware {
                 : '';
 
             if (!apiKey) {
-                this.endRequest(403, 'Invalid secret api key provided', res);
+                return this.endRequest(403, 'Invalid secret api key provided', res);
             }
 
             const account = await this.accountRepo.getAccountBySecretKey(apiKey);
             if (!account) {
-                this.endRequest(403, 'Invalid secret api key provided', res);
+                return this.endRequest(403, 'Invalid secret api key provided', res);
             }
 
             (req as DecodedExpressRequest).decoded = {