Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract logging middleware #9

Merged
merged 12 commits into from
May 17, 2024
Merged

extract logging middleware #9

merged 12 commits into from
May 17, 2024

Conversation

gimmyxd
Copy link
Member

@gimmyxd gimmyxd commented Apr 25, 2024

No description provided.

@coveralls
Copy link

coveralls commented Apr 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9096475610

Details

  • 2 of 22 (9.09%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 38.667%
Changes Missing Coverage Covered Lines Changed/Added Lines %
grpcutil/middlewares/gerr/gerr_middleware.go 2 4 50.0%
grpcutil/middlewares/tracing/tracing_middleware.go 0 18 0.0%
Totals Coverage Status
Change from base Build 5267397134: 0.3%
Covered Lines: 145
Relevant Lines: 375
💛 - Coveralls

@gimmyxd gimmyxd requested a review from ronenh April 25, 2024 15:15
ronenh
ronenh reviewed Apr 30, 2024
View reviewed changes
Copy link
Contributor

@ronenh ronenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

go.work.sum Outdated Show resolved Hide resolved
@gimmyxd gimmyxd marked this pull request as ready for review May 8, 2024 10:34
@gimmyxd gimmyxd requested a review from ronenh May 8, 2024 10:35
@gimmyxd gimmyxd requested a review from ronenh May 16, 2024 10:32
@gimmyxd gimmyxd merged commit 1214be0 into main May 17, 2024
2 checks passed
@gimmyxd gimmyxd deleted the logging_middleware branch May 17, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronenh ronenh ronenh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gimmyxd @coveralls @ronenh