Skip to content

Commit

Permalink
fix(launch): Ensure resume does not push sensitive info (wandb#5807)
Browse files Browse the repository at this point in the history
  • Loading branch information
KyleGoyette authored Jun 28, 2023
1 parent b7756ef commit 69b2b0e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion wandb/sdk/launch/_project_spec.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def __init__(
# runner, so we need to pop the builder key out
resource_args_build = resource_args.get(resource, {}).pop("builder", {})
self.resource = resource
self.resource_args = resource_args
self.resource_args = resource_args.copy()
self.sweep_id = sweep_id
self.python_version: Optional[str] = launch_spec.get("python_version")
self.accelerator_base_image: Optional[str] = resource_args_build.get(
Expand Down
2 changes: 1 addition & 1 deletion wandb/sdk/launch/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
r"^https?://localhost"
) # for testing, not sure if we wanna keep this

API_KEY_REGEX = r"WANDB_API_KEY=\w+"
API_KEY_REGEX = r"WANDB_API_KEY=\w+(-\w+)?"

MACRO_REGEX = re.compile(r"\$\{(\w+)\}")

Expand Down

0 comments on commit 69b2b0e

Please sign in to comment.