Skip to content

Commit

Permalink
update node and rebuild
Browse files Browse the repository at this point in the history
  • Loading branch information
Jeff Dickey committed Apr 10, 2017
1 parent 6c730ac commit c71fd23
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
.SECONDEXPANSION:

NPM_VERSION=3.10.10
NODE_VERSION=6.9.5
NPM_VERSION=4.2.0
NODE_VERSION=7.8.0

DIST_DIR?=dist
CACHE_DIR?=tmp/cache
Expand Down
5 changes: 5 additions & 0 deletions plugins.go
Original file line number Diff line number Diff line change
Expand Up @@ -492,6 +492,11 @@ func (p *Plugins) MigrateRubyPlugins() {
}
}

// Rebuild the plugins when node version changes
func (p *Plugins) Rebuild() {
p.execNpm("rebuild")
}

func (p *Plugins) addToCache(plugin *Plugin) {
contains := func(name string) int {
for i, plugin := range p.plugins {
Expand Down
1 change: 1 addition & 0 deletions update.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ func Update(channel string) {
touchAutoupdateFile()
SubmitAnalytics()
UserPlugins.Update()
UserPlugins.Rebuild()
UserPlugins.MigrateRubyPlugins()
deleteOldPluginsDirectory()
updateCLI(channel)
Expand Down

0 comments on commit c71fd23

Please sign in to comment.