Skip to content

Commit

Permalink
Update documentation for command line args in FlutterProjectArgs. (fl…
Browse files Browse the repository at this point in the history
  • Loading branch information
chinmaygarde authored Feb 7, 2019
1 parent 4e13ede commit 4f3eb42
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
4 changes: 2 additions & 2 deletions common/settings.h
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@ struct Settings {
std::function<void(int64_t)> idle_notification_callback;
// A callback given to the embedder to react to unhandled exceptions in the
// running Flutter application. This callback is made on an internal engine
// managed thread and embedders must thread as necessary. Performing blocking
// calls in this callback will cause applications to jank.
// managed thread and embedders must re-thread as necessary. Performing
// blocking calls in this callback will cause applications to jank.
UnhandledExceptionCallback unhandled_exception_callback;
bool enable_software_rendering = false;
bool skia_deterministic_rendering_on_cpu = false;
Expand Down
8 changes: 8 additions & 0 deletions shell/platform/embedder/embedder.h
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,14 @@ typedef struct {
// The command line arguments used to initialize the project. The strings can
// be collected after the call to |FlutterEngineRun| returns. The strings must
// be NULL terminated.
// Note: The first item in the command line (if specificed at all) is
// interpreted as the executable name. So if an engine flag needs to be passed
// into the same, it needs to not be the very first item in the list. The set
// of engine flags are only meant to control unstable features in the engine.
// Deployed applications should not pass any command line arguments at all as
// they may affect engine stability at runtime in the presence of unsanitized
// input. The list of currently recognized engine flags and their descriptions
// can be retrieved from the |switches.h| engine source file.
const char* const* command_line_argv;
// The callback invoked by the engine in order to give the embedder the chance
// to respond to platform messages from the Dart application. The callback
Expand Down

0 comments on commit 4f3eb42

Please sign in to comment.