Skip to content

Commit

Permalink
cloudstack: add nic operation (ansible#26168)
Browse files Browse the repository at this point in the history
* CloudStack: Remove networkid parameter in global list

* New module for CloudStack VM's Nic

Closes ansible#25911

* Review changes
  • Loading branch information
marcaurele authored and resmo committed Jul 7, 2017
1 parent f8982dc commit ee8ce99
Show file tree
Hide file tree
Showing 2 changed files with 265 additions and 1 deletion.
1 change: 0 additions & 1 deletion lib/ansible/module_utils/cloudstack.py
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,6 @@ def get_vm(self, key=None):
'domainid': self.get_domain(key='id'),
'projectid': self.get_project(key='id'),
'zoneid': self.get_zone(key='id'),
'networkid': self.get_network(key='id'),
}
vms = self.cs.listVirtualMachines(**args)
if vms:
Expand Down
265 changes: 265 additions & 0 deletions lib/ansible/modules/cloud/cloudstack/cs_instance_nic.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,265 @@
#!/usr/bin/python
# -*- coding: utf-8 -*-
#
# (c) 2017, Marc-Aurèle Brothier @marcaurele
#
# This file is part of Ansible
#
# Ansible is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# Ansible is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Ansible. If not, see <http://www.gnu.org/licenses/>.

ANSIBLE_METADATA = {'metadata_version': '1.0',
'status': ['preview'],
'supported_by': 'community'}


DOCUMENTATION = '''
---
module: cs_instance_nic
short_description: Manages NICs of an instance on Apache CloudStack based clouds.
description:
- Add and remove nic to and from network
version_added: "2.4"
author: "Marc-Aurèle Brothier (@marcaurele)"
options:
vm:
description:
- Name of instance.
required: true
aliases: ['name']
network:
description:
- Name of the network.
required: true
vpc:
description:
- Name of the VPC the C(vm) is related to.
required: false
default: null
domain:
description:
- Domain the instance is related to.
required: false
default: null
account:
description:
- Account the instance is related to.
required: false
default: null
project:
description:
- Name of the project the instance is deployed in.
required: false
default: null
zone:
description:
- Name of the zone in which the instance is deployed in.
- If not set, default zone is used.
required: false
default: null
state:
description:
- State of the nic.
required: false
default: "present"
choices: [ 'present', 'absent' ]
poll_async:
description:
- Poll async jobs until job has finished.
required: false
default: true
extends_documentation_fragment: cloudstack
'''

EXAMPLES = '''
# Add a nic on another network
- local_action:
module: cs_instance_nic
vm: privnet
network: privNetForBasicZone
# Remove a secondary nic
- local_action:
module: cs_instance_nic
vm: privnet
state: absent
network: privNetForBasicZone
'''

RETURN = '''
---
id:
description: UUID of the nic.
returned: success
type: string
sample: 87b1e0ce-4e01-11e4-bb66-0050569e64b8
vm:
description: Name of the VM.
returned: success
type: string
sample: web-01
ip_address:
description: Primary IP of the NIC.
returned: success
type: string
sample: 10.10.10.10
netmask:
description: Netmask of the NIC.
returned: success
type: string
sample: 255.255.255.0
mac_address:
description: MAC address of the NIC.
returned: success
type: string
sample: 02:00:33:31:00:e4
network:
description: Name of the network if not default.
returned: success
type: string
sample: sync network
domain:
description: Domain the VM is related to.
returned: success
type: string
sample: example domain
account:
description: Account the VM is related to.
returned: success
type: string
sample: example account
project:
description: Name of project the VM is related to.
returned: success
type: string
sample: Production
'''

from ansible.module_utils.basic import AnsibleModule
from ansible.module_utils.cloudstack import (AnsibleCloudStack,
cs_argument_spec,
cs_required_together)
from cs import CloudStackException


class AnsibleCloudStackInstanceNic(AnsibleCloudStack):

def __init__(self, module):
super(AnsibleCloudStackInstanceNic, self).__init__(module)
self.nic = None
self.returns = {
'ipaddress': 'ip_address',
'macaddress': 'mac_address',
'netmask': 'netmask',
}

def get_nic(self):
if self.nic:
return self.nic
args = {
'virtualmachineid': self.get_vm(key='id'),
'networkid': self.get_network(key='id'),
}
nics = self.cs.listNics(**args)
if nics:
self.nic = nics['nic'][0]
return self.nic
return None

def add_nic(self):
self.result['changed'] = True
args = {
'virtualmachineid': self.get_vm(key='id'),
'networkid': self.get_network(key='id'),
}
if not self.module.check_mode:
res = self.cs.addNicToVirtualMachine(**args)
if 'errortext' in res:
self.module.fail_json(msg="Failed: '%s'" % res['errortext'])

vm = self.poll_job(res, 'virtualmachine')
self.nic = vm['nic'][0]
return self.nic

def remove_nic(self):
self.result['changed'] = True
args = {
'virtualmachineid': self.get_vm(key='id'),
'nicid': self.get_nic()['id'],
}
if not self.module.check_mode:
res = self.cs.removeNicFromVirtualMachine(**args)
if 'errortext' in res:
self.module.fail_json(msg="Failed: '%s'" % res['errortext'])
return self.nic

def present_nic(self):
nic = self.get_nic()
if nic:
return nic
return self.add_nic()

def absent_nic(self):
nic = self.get_nic()
if nic:
return self.remove_nic()
return self.nic

def get_result(self, nic):
super(AnsibleCloudStackInstanceNic, self).get_result(nic)
if nic and not self.module.params.get('network'):
self.module.params['network'] = nic.get('networkid')
self.result['network'] = self.get_network(key='name')
self.result['vm'] = self.get_vm(key='name')
return self.result


def main():
argument_spec = cs_argument_spec()
argument_spec.update(dict(
vm=dict(required=True, aliases=['name']),
network=dict(required=True),
vpc=dict(default=None),
state=dict(choices=['present', 'absent'], default='present'),
domain=dict(default=None),
account=dict(default=None),
project=dict(default=None),
zone=dict(default=None),
poll_async=dict(type='bool', default=True),
))

module = AnsibleModule(
argument_spec=argument_spec,
required_together=cs_required_together(),
supports_check_mode=True,
)

try:
acs_nic = AnsibleCloudStackInstanceNic(module)

state = module.params.get('state')

if state == 'absent':
nic = acs_nic.absent_nic()
else:
nic = acs_nic.present_nic()

result = acs_nic.get_result(nic)

except CloudStackException as e:
module.fail_json(msg='CloudStackException: %s' % str(e))

module.exit_json(**result)

if __name__ == '__main__':
main()

0 comments on commit ee8ce99

Please sign in to comment.