Skip to content

Commit

Permalink
klist: use same naming scheme as hlist for klist_add_after()
Browse files Browse the repository at this point in the history
The name was modified from hlist_add_after() to hlist_add_behind() when
adjusting the order of arguments to match the one with
klist_add_after().  This is necessary to break old code when it would
use it the wrong way.

Make klist follow this naming scheme for consistency.

Signed-off-by: Ken Helias <[email protected]>
Cc: "Paul E. McKenney" <[email protected]>
Cc: Christoph Hellwig <[email protected]>
Cc: Hugh Dickins <[email protected]>
Cc: Jeff Kirsher <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Ken Helias authored and torvalds committed Aug 7, 2014
1 parent 1d02328 commit 0f9859c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion include/linux/klist.h
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ struct klist_node {

extern void klist_add_tail(struct klist_node *n, struct klist *k);
extern void klist_add_head(struct klist_node *n, struct klist *k);
extern void klist_add_after(struct klist_node *n, struct klist_node *pos);
extern void klist_add_behind(struct klist_node *n, struct klist_node *pos);
extern void klist_add_before(struct klist_node *n, struct klist_node *pos);

extern void klist_del(struct klist_node *n);
Expand Down
6 changes: 3 additions & 3 deletions lib/klist.c
Original file line number Diff line number Diff line change
Expand Up @@ -140,11 +140,11 @@ void klist_add_tail(struct klist_node *n, struct klist *k)
EXPORT_SYMBOL_GPL(klist_add_tail);

/**
* klist_add_after - Init a klist_node and add it after an existing node
* klist_add_behind - Init a klist_node and add it after an existing node
* @n: node we're adding.
* @pos: node to put @n after
*/
void klist_add_after(struct klist_node *n, struct klist_node *pos)
void klist_add_behind(struct klist_node *n, struct klist_node *pos)
{
struct klist *k = knode_klist(pos);

Expand All @@ -153,7 +153,7 @@ void klist_add_after(struct klist_node *n, struct klist_node *pos)
list_add(&n->n_node, &pos->n_node);
spin_unlock(&k->k_lock);
}
EXPORT_SYMBOL_GPL(klist_add_after);
EXPORT_SYMBOL_GPL(klist_add_behind);

/**
* klist_add_before - Init a klist_node and add it before an existing node
Expand Down

0 comments on commit 0f9859c

Please sign in to comment.