Skip to content

Commit

Permalink
PM: hibernate: Freeze kernel threads in software_resume()
Browse files Browse the repository at this point in the history
Currently the kernel threads are not frozen in software_resume(), so
between dpm_suspend_start(PMSG_QUIESCE) and resume_target_kernel(),
system_freezable_power_efficient_wq can still try to submit SCSI
commands and this can cause a panic since the low level SCSI driver
(e.g. hv_storvsc) has quiesced the SCSI adapter and can not accept
any SCSI commands: https://lkml.org/lkml/2020/4/10/47

At first I posted a fix (https://lkml.org/lkml/2020/4/21/1318) trying
to resolve the issue from hv_storvsc, but with the help of
Bart Van Assche, I realized it's better to fix software_resume(),
since this looks like a generic issue, not only pertaining to SCSI.

Cc: All applicable <[email protected]>
Signed-off-by: Dexuan Cui <[email protected]>
Signed-off-by: Rafael J. Wysocki <[email protected]>
  • Loading branch information
dcui authored and rafaeljw committed Apr 27, 2020
1 parent 6a8b55e commit 2351f8d
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions kernel/power/hibernate.c
Original file line number Diff line number Diff line change
Expand Up @@ -898,6 +898,13 @@ static int software_resume(void)
error = freeze_processes();
if (error)
goto Close_Finish;

error = freeze_kernel_threads();
if (error) {
thaw_processes();
goto Close_Finish;
}

error = load_image_and_restore();
thaw_processes();
Finish:
Expand Down

0 comments on commit 2351f8d

Please sign in to comment.