Skip to content

Commit

Permalink
media: Kconfig: don't use visible for device type select
Browse files Browse the repository at this point in the history
While making the menu invisible seemed a good idea, there's
a drawback: when the menu is not visible, it is not parsing
the "default" dependency.

So, instead, let's just avoid the items at the menu to be
prompted, by using the "prompt ... if" construction.

Signed-off-by: Mauro Carvalho Chehab <[email protected]>
  • Loading branch information
mchehab committed Apr 14, 2020
1 parent f48fd15 commit b6a7d1b
Showing 1 changed file with 16 additions and 9 deletions.
25 changes: 16 additions & 9 deletions drivers/media/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -57,37 +57,40 @@ config MEDIA_SUBDRV_AUTOSELECT
If unsure say Y.

menu "Media device types"
visible if MEDIA_SUPPORT_FILTER

#
# Multimedia support - automatically enable V4L2 and DVB core
#
config MEDIA_CAMERA_SUPPORT
bool "Cameras and video grabbers"
bool
prompt "Cameras and video grabbers" if MEDIA_SUPPORT_FILTER
default y if !MEDIA_SUPPORT_FILTER
help
Enable support for webcams and video grabbers.

Say Y when you have a webcam or a video capture grabber board.

config MEDIA_ANALOG_TV_SUPPORT
bool "Analog TV"
bool
prompt "Analog TV" if MEDIA_SUPPORT_FILTER
default y if !MEDIA_SUPPORT_FILTER
help
Enable analog TV support.

Say Y when you have a board with analog TV support.

config MEDIA_DIGITAL_TV_SUPPORT
bool "Digital TV"
bool
prompt "Digital TV" if MEDIA_SUPPORT_FILTER
default y if !MEDIA_SUPPORT_FILTER
help
Enable digital TV support.

Say Y when you have a board with digital TV support.

config MEDIA_RADIO_SUPPORT
bool "AM/FM radio receivers/transmitters"
bool
prompt "AM/FM radio receivers/transmitters" if MEDIA_SUPPORT_FILTER
default y if !MEDIA_SUPPORT_FILTER
help
Enable AM/FM radio support.
Expand All @@ -98,15 +101,17 @@ config MEDIA_RADIO_SUPPORT
Say Y when you have a board with radio support.

config MEDIA_SDR_SUPPORT
bool "Software defined radio"
bool
prompt "Software defined radio" if MEDIA_SUPPORT_FILTER
default y if !MEDIA_SUPPORT_FILTER
help
Enable software defined radio support.

Say Y when you have a software defined radio device.

config MEDIA_CEC_SUPPORT
bool "HDMI CEC"
bool
prompt "HDMI CEC support" if MEDIA_SUPPORT_FILTER
default y if !MEDIA_SUPPORT_FILTER
help
Enable support for HDMI CEC (Consumer Electronics Control),
Expand All @@ -116,7 +121,8 @@ config MEDIA_CEC_SUPPORT
adapter that supports HDMI CEC.

config MEDIA_PLATFORM_SUPPORT
bool "Platform-specific devices"
bool
prompt "Platform-specific devices" if MEDIA_SUPPORT_FILTER
default y if !MEDIA_SUPPORT_FILTER
help
Enable support for complex cameras, codecs, and other hardware
Expand All @@ -129,7 +135,8 @@ config MEDIA_PLATFORM_SUPPORT
Say Y when you want to be able so see such devices.

config MEDIA_TEST_SUPPORT
bool "Test drivers"
bool
prompt "Test drivers" if MEDIA_SUPPORT_FILTER
default y if !MEDIA_SUPPORT_FILTER
help
Those drivers should not be used on production Kernels, but
Expand Down

0 comments on commit b6a7d1b

Please sign in to comment.