Skip to content

Commit

Permalink
selftests/powerpc: Add a test of sigreturning to an unaligned address
Browse files Browse the repository at this point in the history
Add a test of sigreturning to an unaligned address (low two bits set).
This should have no effect because the hardware will mask those bits.
However it previously falsely triggered a warning when
CONFIG_PPC_RFI_SRR_DEBUG=y.

Signed-off-by: Michael Ellerman <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
  • Loading branch information
mpe committed Dec 24, 2021
1 parent fd1eaaa commit beeac53
Show file tree
Hide file tree
Showing 3 changed files with 45 additions and 0 deletions.
1 change: 1 addition & 0 deletions tools/testing/selftests/powerpc/signal/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ sigfuz
sigreturn_vdso
sig_sc_double_restart
sigreturn_kernel
sigreturn_unaligned
1 change: 1 addition & 0 deletions tools/testing/selftests/powerpc/signal/Makefile
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# SPDX-License-Identifier: GPL-2.0
TEST_GEN_PROGS := signal signal_tm sigfuz sigreturn_vdso sig_sc_double_restart
TEST_GEN_PROGS += sigreturn_kernel
TEST_GEN_PROGS += sigreturn_unaligned

CFLAGS += -maltivec
$(OUTPUT)/signal_tm: CFLAGS += -mhtm
Expand Down
43 changes: 43 additions & 0 deletions tools/testing/selftests/powerpc/signal/sigreturn_unaligned.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
// SPDX-License-Identifier: GPL-2.0
/*
* Test sigreturn to an unaligned address, ie. low 2 bits set.
* Nothing bad should happen.
* This was able to trigger warnings with CONFIG_PPC_RFI_SRR_DEBUG=y.
*/

#include <signal.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <ucontext.h>
#include <unistd.h>

#include "utils.h"


static void sigusr1_handler(int signo, siginfo_t *info, void *ptr)
{
ucontext_t *uc = ptr;

UCONTEXT_NIA(uc) |= 3;
}

static int test_sigreturn_unaligned(void)
{
struct sigaction action;

memset(&action, 0, sizeof(action));
action.sa_sigaction = sigusr1_handler;
action.sa_flags = SA_SIGINFO;

FAIL_IF(sigaction(SIGUSR1, &action, NULL) == -1);

raise(SIGUSR1);

return 0;
}

int main(void)
{
return test_harness(test_sigreturn_unaligned, "sigreturn_unaligned");
}

0 comments on commit beeac53

Please sign in to comment.