Skip to content

Commit

Permalink
Constraints generation runs regardless from test status (apache#11838)
Browse files Browse the repository at this point in the history
Constraints generation did not run when tests were failing
but this was wrong. In case of tests that fail due to constraints
upgrade we neeed to see the output of constraint generation, to
know which constraints failed. Only pushing the constraint
should be limited to the case where everything succeeded.

This should make investigation of problems similar to apache#11837 much
easier.
  • Loading branch information
potiuk authored Oct 27, 2020
1 parent b161642 commit 73884e8
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -893,18 +893,11 @@ jobs:
fail-fast: false
needs:
- build-info
- static-checks
- static-checks-pylint
- tests-sqlite
- tests-mysql
- tests-postgres
- tests-kubernetes
env:
PYTHON_MAJOR_MINOR_VERSION: ${{ matrix.python-version }}
if: >
needs.build-info.outputs.basic-checks-only == 'false' &&
(github.ref == 'refs/heads/master' || github.ref == 'refs/heads/v1-10-test' ) &&
github.event_name != 'pull' &&
(github.repository == 'apache/airflow' || github.event_name != 'schedule')
steps:
- name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
Expand All @@ -929,11 +922,18 @@ jobs:
timeout-minutes: 10
name: "Constraints push"
runs-on: ubuntu-latest
needs: [build-info, constraints]
needs:
- build-info
- constraints
- static-checks
- static-checks-pylint
- tests-sqlite
- tests-mysql
- tests-postgres
- tests-kubernetes
if: >
needs.build-info.outputs.basic-checks-only == 'false' &&
(github.ref == 'refs/heads/master' || github.ref == 'refs/heads/v1-10-test' ) &&
github.event_name != 'pull' &&
(github.repository == 'apache/airflow' || github.event_name != 'schedule')
steps:
- name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
Expand Down

0 comments on commit 73884e8

Please sign in to comment.