Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: runfiles is now optional with rules_js #177

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: runfiles is now optional with rules_js #177

wants to merge 1 commit into from

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented Jan 6, 2024 •
edited
Loading

This only affects Windows CI.

Type of change

  • Chore (any other change that doesn't affect source or test files, such as configuration)

Test plan

  • Covered by existing test cases

Windows CI

@gregmagolan gregmagolan requested a review from jbedard January 6, 2024 09:02
@gregmagolan gregmagolan marked this pull request as draft January 6, 2024 10:10
@gregmagolan gregmagolan force-pushed the runfiles_optional__windows branch from 964d782 to 7e46202 Compare January 8, 2024 01:19
@gregmagolan gregmagolan force-pushed the runfiles_optional__windows branch from 7e46202 to 5a6dc30 Compare January 8, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbedard jbedard jbedard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Open Source
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregmagolan @jbedard