Let license errors raise without trying to cleanup sandbox

Before this change if the license acceptance failed and raised an
exception the 'cleanup_sandbox' was called in an ensure. But the
sandbox would not have been created yet so it would fail with an error
like:

Failed to complete #converge action: [Sandbox directory has not yet been
created. Please run Kitchen::Provisioner::ChefGithub#create_sandox
before trying to access the path.]

Signed-off-by: tyler-ball <[email protected]>

lib/kitchen/instance.rb

@@ -405,6 +405,7 @@ def converge_action
         if legacy_ssh_base_driver?
           legacy_ssh_base_converge(state)
         else
+          provisioner.check_license
           provisioner.call(state)
         end
       end

lib/kitchen/provisioner/base.rb

@@ -68,7 +68,6 @@ def initialize(config = {})
       # @raise [ActionFailed] if the action could not be completed
       # rubocop:disable Metrics/AbcSize
       def call(state)
-        check_license
         create_sandbox
         sandbox_dirs = Util.list_directory(sandbox_path)
 

spec/kitchen/instance_spec.rb

@@ -509,6 +509,7 @@ def platform(name = "platform")
       describe "with no state" do
         it "calls Driver#create and Provisioner#call with empty state hash" do
           driver.expects(:create).with({})
+          provisioner.expects(:check_license)
           provisioner.expects(:call)
                      .with { |state| state[:last_action] == "create" }
 

spec/kitchen/provisioner/base_spec.rb

@@ -163,12 +163,6 @@ def sandbox_path
       FakeFS::FileSystem.clear
     end
 
-    it "checks the license" do
-      provisioner.expects(:check_license)
-
-      cmd
-    end
-
     it "creates the sandbox" do
       provisioner.expects(:create_sandbox)