Fix static check failures in PR #218 (#251)

Fix the failed Static Check job here that were observed in #218. Since the PR was created from a fork, I could not push changes to it before merging. related: #206
astronomer · Oct 16, 2024 · 6f31846 · 6f31846
1 parent 93e32e6
commit 6f31846
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 17 deletions.
diff --git a/dagfactory/dagbuilder.py b/dagfactory/dagbuilder.py
@@ -237,30 +237,22 @@ def get_dag_params(self) -> Dict[str, Any]:
                 dag_params["on_failure_callback_file"],
             )
 
-        if utils.check_dict_key(
-            dag_params["default_args"], "on_success_callback_name"
-        ) and utils.check_dict_key(
+        if utils.check_dict_key(dag_params["default_args"], "on_success_callback_name") and utils.check_dict_key(
             dag_params["default_args"], "on_success_callback_file"
         ):
 
-            dag_params["default_args"]["on_success_callback"]: Callable = (
-                utils.get_python_callable(
-                    dag_params["default_args"]["on_success_callback_name"],
-                    dag_params["default_args"]["on_success_callback_file"],
-                )
+            dag_params["default_args"]["on_success_callback"]: Callable = utils.get_python_callable(
+                dag_params["default_args"]["on_success_callback_name"],
+                dag_params["default_args"]["on_success_callback_file"],
             )
 
-        if utils.check_dict_key(
-            dag_params["default_args"], "on_failure_callback_name"
-        ) and utils.check_dict_key(
+        if utils.check_dict_key(dag_params["default_args"], "on_failure_callback_name") and utils.check_dict_key(
             dag_params["default_args"], "on_failure_callback_file"
         ):
 
-            dag_params["default_args"]["on_failure_callback"]: Callable = (
-                utils.get_python_callable(
-                    dag_params["default_args"]["on_failure_callback_name"],
-                    dag_params["default_args"]["on_failure_callback_file"],
-                )
+            dag_params["default_args"]["on_failure_callback"]: Callable = utils.get_python_callable(
+                dag_params["default_args"]["on_failure_callback_name"],
+                dag_params["default_args"]["on_failure_callback_file"],
             )
 
         if utils.check_dict_key(dag_params, "template_searchpath"):

diff --git a/tests/test_dagbuilder.py b/tests/test_dagbuilder.py
@@ -417,6 +417,7 @@ def test_make_python_operator():
     assert callable(actual.python_callable)
     assert isinstance(actual, PythonOperator)
 
+
 def test_make_python_operator_with_callable_str():
     td = dagbuilder.DagBuilder("test_dag", DAG_CONFIG, DEFAULT_CONFIG)
     operator = "airflow.operators.python_operator.PythonOperator"
@@ -428,7 +429,8 @@ def test_make_python_operator_with_callable_str():
     assert actual.task_id == "test_task"
     assert callable(actual.python_callable)
     assert isinstance(actual, PythonOperator)
-
+
+
 def test_make_python_operator_missing_param():
     td = dagbuilder.DagBuilder("test_dag", DAG_CONFIG, DEFAULT_CONFIG)
     operator = "airflow.operators.python_operator.PythonOperator"