Skip to content

Commit

Permalink
Add a qmk format-json command that will format JSON files (qmk#12372)
Browse files Browse the repository at this point in the history
* Add a command to format json files

* change to work after rebase

* add test for qmk format-json

* add documentation for qmk format-json

* Update lib/python/qmk/cli/format/json.py
  • Loading branch information
skullydazed authored Mar 25, 2021
1 parent a74846a commit 3e60997
Show file tree
Hide file tree
Showing 15 changed files with 319 additions and 107 deletions.
10 changes: 10 additions & 0 deletions docs/cli_commands.md
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,16 @@ Check your environment and report problems only:

qmk doctor -n

## `qmk format-json`

Formats a JSON file in a (mostly) human-friendly way. Will usually correctly detect the format of the JSON (info.json or keymap.json) but you can override this with `--format` if neccesary.

**Usage**:

```
qmk format-json [-f FORMAT] <json_file>
```

## `qmk info`

Displays information about keyboards and keymaps in QMK. You can use this to get information about a keyboard, show the layouts, display the underlying key matrix, or to pretty-print JSON keymaps.
Expand Down
1 change: 1 addition & 0 deletions lib/python/qmk/cli/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from . import doctor
from . import fileformat
from . import flash
from . import format
from . import generate
from . import hello
from . import info
Expand Down
2 changes: 1 addition & 1 deletion lib/python/qmk/cli/c2json.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

import qmk.keymap
import qmk.path
from qmk.info_json_encoder import InfoJSONEncoder
from qmk.json_encoders import InfoJSONEncoder
from qmk.keyboard import keyboard_folder


Expand Down
1 change: 1 addition & 0 deletions lib/python/qmk/cli/format/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
from . import json
66 changes: 66 additions & 0 deletions lib/python/qmk/cli/format/json.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
"""JSON Formatting Script
Spits out a JSON file formatted with one of QMK's formatters.
"""
import json

from jsonschema import ValidationError
from milc import cli

from qmk.info import info_json
from qmk.json_schema import json_load, keyboard_validate
from qmk.json_encoders import InfoJSONEncoder, KeymapJSONEncoder
from qmk.path import normpath


@cli.argument('json_file', arg_only=True, type=normpath, help='JSON file to format')
@cli.argument('-f', '--format', choices=['auto', 'keyboard', 'keymap'], default='auto', arg_only=True, help='JSON formatter to use (Default: autodetect)')
@cli.subcommand('Generate an info.json file for a keyboard.', hidden=False if cli.config.user.developer else True)
def format_json(cli):
"""Format a json file.
"""
json_file = json_load(cli.args.json_file)

if cli.args.format == 'auto':
try:
keyboard_validate(json_file)
json_encoder = InfoJSONEncoder

except ValidationError as e:
cli.log.warning('File %s did not validate as a keyboard:\n\t%s', cli.args.json_file, e)
cli.log.info('Treating %s as a keymap file.', cli.args.json_file)
json_encoder = KeymapJSONEncoder

elif cli.args.format == 'keyboard':
json_encoder = InfoJSONEncoder
elif cli.args.format == 'keymap':
json_encoder = KeymapJSONEncoder
else:
# This should be impossible
cli.log.error('Unknown format: %s', cli.args.format)
return False

if json_encoder == KeymapJSONEncoder and 'layout' in json_file:
# Attempt to format the keycodes.
layout = json_file['layout']
info_data = info_json(json_file['keyboard'])

if layout in info_data.get('layout_aliases', {}):
layout = json_file['layout'] = info_data['layout_aliases'][layout]

if layout in info_data.get('layouts'):
for layer_num, layer in enumerate(json_file['layers']):
current_layer = []
last_row = 0

for keymap_key, info_key in zip(layer, info_data['layouts'][layout]['layout']):
if last_row != info_key['y']:
current_layer.append('JSON_NEWLINE')
last_row = info_key['y']

current_layer.append(keymap_key)

json_file['layers'][layer_num] = current_layer

# Display the results
print(json.dumps(json_file, cls=json_encoder))
2 changes: 1 addition & 1 deletion lib/python/qmk/cli/generate/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

from qmk.datetime import current_datetime
from qmk.info import info_json
from qmk.info_json_encoder import InfoJSONEncoder
from qmk.json_encoders import InfoJSONEncoder
from qmk.json_schema import json_load
from qmk.keyboard import list_keyboards

Expand Down
2 changes: 1 addition & 1 deletion lib/python/qmk/cli/generate/info_json.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

from qmk.decorators import automagic_keyboard, automagic_keymap
from qmk.info import info_json
from qmk.info_json_encoder import InfoJSONEncoder
from qmk.json_encoders import InfoJSONEncoder
from qmk.json_schema import load_jsonschema
from qmk.keyboard import keyboard_folder
from qmk.path import is_keyboard
Expand Down
2 changes: 1 addition & 1 deletion lib/python/qmk/cli/info.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

from milc import cli

from qmk.info_json_encoder import InfoJSONEncoder
from qmk.json_encoders import InfoJSONEncoder
from qmk.constants import COL_LETTERS, ROW_LETTERS
from qmk.decorators import automagic_keyboard, automagic_keymap
from qmk.keyboard import keyboard_folder, render_layouts, render_layout
Expand Down
2 changes: 1 addition & 1 deletion lib/python/qmk/cli/kle2json.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from kle2xy import KLE2xy

from qmk.converter import kle2qmk
from qmk.info_json_encoder import InfoJSONEncoder
from qmk.json_encoders import InfoJSONEncoder


@cli.argument('filename', help='The KLE raw txt to convert')
Expand Down
96 changes: 0 additions & 96 deletions lib/python/qmk/info_json_encoder.py

This file was deleted.

Loading

0 comments on commit 3e60997

Please sign in to comment.