A couple of comments

athas · Jun 26, 2019 · 475f250 · 475f250
1 parent 2b46b42
commit 475f250
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/lib/AST/ASTContext.cpp b/lib/AST/ASTContext.cpp
@@ -2412,6 +2412,7 @@ AnyFunctionType::Param swift::computeSelfParam(AbstractFunctionDecl *AFD,
     isStatic = FD->isStatic();
     selfAccess = FD->getSelfAccessKind();
 
+    // `self`s type for subscripts and properties
     if (auto *AD = dyn_cast<AccessorDecl>(AFD)) {
       if (wantDynamicSelf && AD->getStorage()
           ->getValueInterfaceType()->hasDynamicSelfType())

diff --git a/lib/Sema/TypeCheckType.cpp b/lib/Sema/TypeCheckType.cpp
@@ -1051,6 +1051,8 @@ static std::string getDeclNameFromContext(DeclContext *dc,
 //
 // SE-0068 is "Expanding Swift Self to class members and value types"
 // Returns a Type if 'Self' is available in the current implementation.
+// Errs on the side of returning `Self` in most circumstances which is
+// subsequently validated in the various vistors in TypeCheckDecl.cpp.
 //
 // https://github.com/apple/swift-evolution/blob/master/proposals/0068-universal-self.md
 //