Remove generics from HiveColumnStatistics

Never used, not needed
atris · May 29, 2018 · a49a78d · a49a78d
1 parent 5b9cdd9
commit a49a78d
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 14 deletions.
diff --git a/presto-hive/src/main/java/com/facebook/presto/hive/metastore/HiveColumnStatistics.java b/presto-hive/src/main/java/com/facebook/presto/hive/metastore/HiveColumnStatistics.java
@@ -18,10 +18,10 @@
 import java.util.OptionalDouble;
 import java.util.OptionalLong;
 
-public class HiveColumnStatistics<T>
+public class HiveColumnStatistics
 {
-    private final Optional<T> lowValue;
-    private final Optional<T> highValue;
+    private final Optional<?> lowValue;
+    private final Optional<?> highValue;
     private final OptionalLong maxColumnLength;
     private final OptionalDouble averageColumnLength;
     private final OptionalLong trueCount;
@@ -30,8 +30,8 @@ public class HiveColumnStatistics<T>
     private final OptionalLong distinctValuesCount;
 
     public HiveColumnStatistics(
-            Optional<T> lowValue,
-            Optional<T> highValue,
+            Optional<?> lowValue,
+            Optional<?> highValue,
             OptionalLong maxColumnLength,
             OptionalDouble averageColumnLength,
             OptionalLong trueCount,
@@ -49,12 +49,12 @@ public HiveColumnStatistics(
         this.distinctValuesCount = distinctValuesCount;
     }
 
-    public Optional<T> getLowValue()
+    public Optional<?> getLowValue()
     {
         return lowValue;
     }
 
-    public Optional<T> getHighValue()
+    public Optional<?> getHighValue()
     {
         return highValue;
     }

diff --git a/presto-hive/src/main/java/com/facebook/presto/hive/metastore/thrift/ThriftMetastoreUtil.java b/presto-hive/src/main/java/com/facebook/presto/hive/metastore/thrift/ThriftMetastoreUtil.java
@@ -237,7 +237,7 @@ public static HiveColumnStatistics fromMetastoreApiColumnStatistics(ColumnStatis
     {
         if (columnStatistics.getStatsData().isSetLongStats()) {
             LongColumnStatsData longStatsData = columnStatistics.getStatsData().getLongStats();
-            return new HiveColumnStatistics<>(
+            return new HiveColumnStatistics(
                     longStatsData.isSetLowValue() ? Optional.of(longStatsData.getLowValue()) : Optional.empty(),
                     longStatsData.isSetHighValue() ? Optional.of(longStatsData.getHighValue()) : Optional.empty(),
                     OptionalLong.empty(),
@@ -249,7 +249,7 @@ public static HiveColumnStatistics fromMetastoreApiColumnStatistics(ColumnStatis
         }
         else if (columnStatistics.getStatsData().isSetDoubleStats()) {
             DoubleColumnStatsData doubleStatsData = columnStatistics.getStatsData().getDoubleStats();
-            return new HiveColumnStatistics<>(
+            return new HiveColumnStatistics(
                     doubleStatsData.isSetLowValue() ? Optional.of(doubleStatsData.getLowValue()) : Optional.empty(),
                     doubleStatsData.isSetHighValue() ? Optional.of(doubleStatsData.getHighValue()) : Optional.empty(),
                     OptionalLong.empty(),
@@ -261,7 +261,7 @@ else if (columnStatistics.getStatsData().isSetDoubleStats()) {
         }
         else if (columnStatistics.getStatsData().isSetDecimalStats()) {
             DecimalColumnStatsData decimalStatsData = columnStatistics.getStatsData().getDecimalStats();
-            return new HiveColumnStatistics<>(
+            return new HiveColumnStatistics(
                     decimalStatsData.isSetLowValue() ? fromMetastoreDecimal(decimalStatsData.getLowValue()) : Optional.empty(),
                     decimalStatsData.isSetHighValue() ? fromMetastoreDecimal(decimalStatsData.getHighValue()) : Optional.empty(),
                     OptionalLong.empty(),
@@ -273,7 +273,7 @@ else if (columnStatistics.getStatsData().isSetDecimalStats()) {
         }
         else if (columnStatistics.getStatsData().isSetBooleanStats()) {
             BooleanColumnStatsData booleanStatsData = columnStatistics.getStatsData().getBooleanStats();
-            return new HiveColumnStatistics<>(
+            return new HiveColumnStatistics(
                     Optional.empty(),
                     Optional.empty(),
                     OptionalLong.empty(),
@@ -286,7 +286,7 @@ else if (columnStatistics.getStatsData().isSetBooleanStats()) {
         }
         else if (columnStatistics.getStatsData().isSetDateStats()) {
             DateColumnStatsData dateStatsData = columnStatistics.getStatsData().getDateStats();
-            return new HiveColumnStatistics<>(
+            return new HiveColumnStatistics(
                     dateStatsData.isSetLowValue() ? fromMetastoreDate(dateStatsData.getLowValue()) : Optional.empty(),
                     dateStatsData.isSetHighValue() ? fromMetastoreDate(dateStatsData.getHighValue()) : Optional.empty(),
                     OptionalLong.empty(),
@@ -298,7 +298,7 @@ else if (columnStatistics.getStatsData().isSetDateStats()) {
         }
         else if (columnStatistics.getStatsData().isSetStringStats()) {
             StringColumnStatsData stringStatsData = columnStatistics.getStatsData().getStringStats();
-            return new HiveColumnStatistics<>(
+            return new HiveColumnStatistics(
                     Optional.empty(),
                     Optional.empty(),
                     stringStatsData.isSetMaxColLen() ? OptionalLong.of(stringStatsData.getMaxColLen()) : OptionalLong.empty(),
@@ -310,7 +310,7 @@ else if (columnStatistics.getStatsData().isSetStringStats()) {
         }
         else if (columnStatistics.getStatsData().isSetBinaryStats()) {
             BinaryColumnStatsData binaryStatsData = columnStatistics.getStatsData().getBinaryStats();
-            return new HiveColumnStatistics<>(
+            return new HiveColumnStatistics(
                     Optional.empty(),
                     Optional.empty(),
                     binaryStatsData.isSetMaxColLen() ? OptionalLong.of(binaryStatsData.getMaxColLen()) : OptionalLong.empty(),