build, linter, errcheck: lint tests/libnode

Signed-off-by: Miguel Duarte Barroso <[email protected]>
attlee-wang · Aug 4, 2022 · cdbc0a9 · cdbc0a9
1 parent fa3eca8
commit cdbc0a9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/nogo_config.json b/nogo_config.json
@@ -151,7 +151,6 @@
       "tools/": "KubeVirt tools do not pass errcheck yet",
       "tests/console": "tests/console does not pass errcheck yet",
       "tests/libstorage/": "tests/libstorage does not pass errcheck yet",
-      "tests/libnode/": "libnode does not pass errcheck yet",
       "tests/monitoring/": "tests/monitoring does not pass errcheck yet",
       "tests/network/": "tests/network/ pkg does not pass errcheck yet",
       "tests/reporter/": "tests/reporter pkg does not pass errcheck yet",

diff --git a/tests/libnode/node.go b/tests/libnode/node.go
@@ -68,9 +68,13 @@ func CleanNodes() {
 
 		k8sClient := clientcmd.GetK8sCmdClient()
 		if k8sClient == "oc" {
-			clientcmd.RunCommandWithNS("", k8sClient, "adm", "uncordon", node.Name)
+			if _, _, err := clientcmd.RunCommandWithNS("", k8sClient, "adm", "uncordon", node.Name); err != nil {
+				panic(fmt.Sprintf("could not uncordon the node %s", node.Name))
+			}
 		} else {
-			clientcmd.RunCommandWithNS("", k8sClient, "uncordon", node.Name)
+			if _, _, err := clientcmd.RunCommandWithNS("", k8sClient, "uncordon", node.Name); err != nil {
+				panic(fmt.Sprintf("could not uncordon the node %s", node.Name))
+			}
 		}
 
 		found := false