Increase wait times for window_opened_by spec due to slow Travis CI

aubinlrx · Aug 24, 2014 · 23c4091 · 23c4091
1 parent 304e2fb
commit 23c4091
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/lib/capybara/spec/session/window/window_opened_by_spec.rb b/lib/capybara/spec/session/window/window_opened_by_spec.rb
@@ -16,10 +16,11 @@
 
   context 'with :wait option' do
     it 'should raise error if value of :wait is less than timeout' do
-      Capybara.using_wait_time 1 do
+      # So large value is used as `driver.window_handles` takes up to 800 ms on Travis
+      Capybara.using_wait_time 2 do
         expect do
-          @session.window_opened_by(wait: 0.4) do
-            @session.find(:css, '#openWindowWithTimeout').click
+          @session.window_opened_by(wait: 0.8) do
+            @session.find(:css, '#openWindowWithLongerTimeout').click
           end
         end.to raise_error(Capybara::WindowError, zero_windows_message)
       end

diff --git a/lib/capybara/spec/views/with_windows.erb b/lib/capybara/spec/views/with_windows.erb
@@ -16,6 +16,13 @@
         return false;
       });
 
+      $('#openWindowWithLongerTimeout').click(function(){
+        setTimeout(function(){
+          window.open('/popup_one', 'firstPopup');
+        }, 1400);
+        return false;
+      });
+
       $('#openTwoWindows').click(function() {
         window.open('/popup_one', 'firstPopup');
         window.open('/popup_two', 'secondPopup');
@@ -29,6 +36,8 @@
 
     <button id="openWindowWithTimeout">Open new window with timeout</button>
 
+    <button id="openWindowWithLongerTimeout">Open new window with longer timeout</button>
+
     <button id="openTwoWindows">Open two windows</button>
 
     <button id="doesNotOpenWindows">Does not open windows</button>