-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snow VM #1831
Draft
aaronbuchwald
wants to merge
16
commits into
main
Choose a base branch
from
snow-vm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Snow VM #1831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronbuchwald
added
the
DO NOT MERGE
This PR is not meant to be merged in its current state
label
Dec 10, 2024
Next steps:
Most importantly break this PR up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor is intended to separate out maintenance of the AvalancheGo specific invariants and initialization from the VM package.
Prior to this PR, the VM package:
snowman.Block
,block.ChainVM
, andblock.StateSyncableVM
interfacesThis PR aims to reduce the responsibilities of the VM package as much as possible. Note: #1744 moved the
StatefulBlock
type out of the chain package and into VM. This continues to remove AvalancheGo specific functionality from the HyperVM specific components.The goal of this refactor is to get to a point where:
snow
package implementssnowman.Block
andblock.ChainVM
and maintains invariants required by consensus enginesnow
package can be tested independently of HyperSDK chain logic that it correctly maintains those invariantssnow
package "decomposes" the AvalancheGo VM interface into components with given defaults and can be overridden by an individual chain (currentlyOptions
, but should be renamed as it doesn't quite fit under this pattern)vm
package tohypervm
vm
package plays the role of initializing all of the required components and implementing a simpler interface that handles the required block state transitionsvm
package that do not need to cover consensus engine edge caseschain.OutputBlock
after accept that can be sent to relevant APIs)