Helios sp1 integration #689
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xSasaPrsic
force-pushed
the
helios-sp1
branch
from
f421178 to
9058edb
Compare
pallets/vector/Cargo.toml
Outdated
| @@ -20,6 +20,9 @@ sp-runtime = { workspace = true, default-features = false } | |||
| sp-std = { workspace = true, default-features = false } | |||
| sp-core = { workspace = true, default-features = false } | |||
| frame-benchmarking = { workspace = true, default-features = false, optional = true } | |||
| # TODO is there a release version? | |||
There was a problem hiding this comment.
The 4.0.0-rc1 tag should be out in the next few days, which you can use. For now, I'd recommend pinning to a specific commit.
pallets/vector/Cargo.toml
Outdated
| @@ -38,6 +41,7 @@ ethabi.workspace = true | |||
| [dev-dependencies] | |||
| pallet-balances = { workspace = true, default-features = false, features = ["std"] } | |||
| pallet-timestamp = { workspace = true, default-features = false } | |||
| sp1-sdk = { git = "https://github.com/succinctlabs/sp1", branch = "dev", default-features = false} | |||
| @@ -164,13 +164,16 @@ pub const ROTATE_VK: &str = r#"{"vk_json":{ | |||
| ] | |||
| }}"#; | |||
|
|
|||
| const SP1_VERIFICATION_KEY: [u8; 32] = | |||
There was a problem hiding this comment.
Add a description for how this is generated.
| ); | ||
| ensure!(is_valid.is_ok(), Error::<T>::VerificationFailed); | ||
|
|
||
| Head::<T>::set(new_head); |
pallets/vector/src/mock.rs
Outdated
| @@ -232,9 +232,9 @@ pub fn new_test_ext() -> sp_io::TestExternalities { | |||
| .unwrap(); | |||
|
|
|||
| vector_bridge::GenesisConfig::<Test> { | |||
| finality_threshold: 461, | |||
| // finality_threshold: 461, | |||
There was a problem hiding this comment.
nit: These should be deleted, rather than commented.
pallets/vector/src/tests.rs
Outdated
| }); | ||
| } | ||
|
|
||
| // #[test] |
0xSasaPrsic
force-pushed
the
helios-sp1
branch
from
c23909b to
22421bb
Compare
0xSasaPrsic
force-pushed
the
helios-sp1
branch
from
22421bb to
e5e1210
Compare
0xSasaPrsic
force-pushed
the
helios-sp1
branch
from
fd13707 to
c898edb
Compare
0xSasaPrsic
force-pushed
the
helios-sp1
branch
from
2be1820 to
caa4878
Compare
0xSasaPrsic
requested review from
markopoloparadox,
Leouarz,
ToufeeqP and
luka-ethernal
Leouarz
approved these changes
Nov 26, 2024
Correct, it needs running benchmarks on the referent machine and re-running build API once the review changes are done on the pallet. |
ToufeeqP
approved these changes
Nov 26, 2024
luka-ethernal
approved these changes
Nov 26, 2024
0xSasaPrsic
force-pushed
the
helios-sp1
branch
from
19704bb to
c177bc5
Compare
This was referenced Dec 2, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Helios sp1 integration.
https://github.com/succinctlabs/sp1-helios/blob/main/contracts/src/SP1LightClient.sol
Please add the labels corresponding to the type of changes your PR introduces:
Description
Related Issues
Testing Performed
Checklist
cargo test.cargo fmt.cargo build --releaseandcargo build --release --features runtime-benchmarks.cargo clippy.