Skip to content

Commit

Permalink
Restore cadence-server builds, previously building the CLI twice (cad…
Browse files Browse the repository at this point in the history
…ence-workflow#5587)

cadence-workflow#5539 / commit a8921b2 unfortunately has a bad bit of copypasta that changed the `cadence-server` build to make the CLI.
This restores that makefile target to what it should be.

tbh I'm not quite sure how this got past CI.  Maybe we don't actually run the binary anywhere as part of an E2E test?
It is fairly quick to notice at least though, since it causes problems quickly.
  • Loading branch information
Groxx authored Jan 9, 2024
1 parent 381182f commit 995e112
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ cadence: $(BINS_DEPEND_ON)
BINS += cadence-server
cadence-server: $(BINS_DEPEND_ON)
$Q echo "compiling cadence-server with OS: $(GOOS), ARCH: $(GOARCH)"
$Q ./scripts/build-with-ldflags.sh -o $@ cmd/tools/cli/main.go
$Q ./scripts/build-with-ldflags.sh -o $@ cmd/server/main.go

BINS += cadence-canary
cadence-canary: $(BINS_DEPEND_ON)
Expand Down

0 comments on commit 995e112

Please sign in to comment.