fix: on sale toggle sortBy (decentraland#1453)

awaisshah228 · Mar 8, 2023 · 9d71fb4 · 9d71fb4
1 parent d89d0aa
commit 9d71fb4
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/webapp/src/components/AssetFilters/AssetFilters.tsx b/webapp/src/components/AssetFilters/AssetFilters.tsx
@@ -10,7 +10,7 @@ import { getSectionFromCategory } from '../../modules/routing/search'
 import { AssetType } from '../../modules/asset/types'
 import { isLandSection } from '../../modules/ui/utils'
 import { View } from '../../modules/ui/types'
-import { Sections } from '../../modules/routing/types'
+import { Sections, SortBy } from '../../modules/routing/types'
 import { LANDFilters } from '../Vendor/decentraland/types'
 import { Menu } from '../Menu'
 import PriceFilter from './PriceFilter'
@@ -107,7 +107,12 @@ export const AssetFilters = ({
 
   const handleOnSaleChange = useCallback(
     (value: boolean) => {
-      onBrowse({ onlyOnSale: value })
+      // when toggling off the on sale filter, we need to reset the sortBy to avoid invalid combinations with the on sale sort options
+      onBrowse(
+        value
+          ? { onlyOnSale: value }
+          : { onlyOnSale: value, sortBy: SortBy.NEWEST }
+      )
     },
     [onBrowse]
   )