lint, network: remove appendAssign error

By removing this extra variable, we always make use of the same slice when appending, this removing the error below: ``` pkg/network/domainspec/generators.go:187:39: appendAssign: append result not assigned to the same slice (gocritic) b.domain.Spec.Devices.Interfaces = append(ifaces[:i], ifaces[i+1:]...) ``` Signed-off-by: Miguel Duarte Barroso <[email protected]>
awanio · Jun 30, 2022 · 015751a · 015751a
1 parent 261bc07
commit 015751a
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/pkg/network/domainspec/generators.go b/pkg/network/domainspec/generators.go
@@ -181,10 +181,12 @@ type SlirpLibvirtSpecGenerator struct {
 func (b *SlirpLibvirtSpecGenerator) Generate() error {
 	// remove slirp interface from domain spec devices interfaces
 	var foundIfaceModelType string
-	ifaces := b.domain.Spec.Devices.Interfaces
-	for i, iface := range ifaces {
+	for i, iface := range b.domain.Spec.Devices.Interfaces {
 		if iface.Alias.GetName() == b.vmiSpecIface.Name {
-			b.domain.Spec.Devices.Interfaces = append(ifaces[:i], ifaces[i+1:]...)
+			b.domain.Spec.Devices.Interfaces = append(
+				b.domain.Spec.Devices.Interfaces[:i],
+				b.domain.Spec.Devices.Interfaces[i+1:]...,
+			)
 			foundIfaceModelType = iface.Model.Type
 			break
 		}