Skip to content

Commit

Permalink
Disable hardlinking of immutable inputs (pantsbuild#18487)
Browse files Browse the repository at this point in the history
As determined in pantsbuild#18162, hardlinking unfortunately does not play well
with any of the implementations of Docker for macOS's filesystem
virtualization.

This change re-disables hardlinking of immutable inputs until pantsbuild#18162
and/or pantsbuild#18153 (which currently plans to switch to using symlinks for
large files) are resolved.
  • Loading branch information
stuhood authored Mar 13, 2023
1 parent 6bb64ed commit 3236b4e
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/rust/engine/fs/store/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,9 @@ const GIGABYTES: usize = 1024 * MEGABYTES;
// NB: These numbers were chosen after micro-benchmarking the code on one machine at the time of
// writing. They were chosen using a rough equation from the microbenchmarks that are optimized
// for somewhere between 2 and 3 uses of the corresponding entry to "break even".
const IMMUTABLE_FILE_SIZE_LIMIT: usize = 512 * KILOBYTES;
// TODO: Temporarily disabled until #18162 and/or #18153 are resolved, since hardlinks do not play
// well with Docker on macOS.
const IMMUTABLE_FILE_SIZE_LIMIT: usize = usize::MAX - 1;

mod local;
#[cfg(test)]
Expand Down

0 comments on commit 3236b4e

Please sign in to comment.