Skip to content

Commit

Permalink
[firebase_performance] Fix incorrect setting of Trace & HttpMetric at…
Browse files Browse the repository at this point in the history
…tributes (firebase#1277)
  • Loading branch information
Salakar authored and bparrishMines committed Feb 28, 2019
1 parent 8bb3bee commit 075298c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,5 @@ Diego Velásquez <[email protected]>
Hajime Nakamura <[email protected]>
Tuyển Vũ Xuân <[email protected]>
Sarthak Verma <[email protected]>
Mike Diarmid <[email protected]>
Invertase <[email protected]>
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ - (void)handleTraceStop:(FlutterMethodCall *)call result:(FlutterResult)result {

NSDictionary *attributes = call.arguments[@"attributes"];
[attributes enumerateKeysAndObjectsUsingBlock:^(NSString *key, NSString *value, BOOL *stop) {
[trace setValue:key forAttribute:value];
[trace setValue:value forAttribute:key];
}];

[trace stop];
Expand Down Expand Up @@ -149,7 +149,7 @@ - (void)handleHttpMetricStop:(FlutterMethodCall *)call result:(FlutterResult)res

NSDictionary *attributes = call.arguments[@"attributes"];
[attributes enumerateKeysAndObjectsUsingBlock:^(NSString *key, NSString *value, BOOL *stop) {
[metric setValue:key forAttribute:value];
[metric setValue:value forAttribute:key];
}];

[metric stop];
Expand Down

0 comments on commit 075298c

Please sign in to comment.