fix: Conda queue env erroring in activate/deactivate cases #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Turn off strict behavior for undefined variables when activating/deactivating during environment exit. * Installing with package update can result in activation, so turn off strict behavior then as well. Signed-off-by: Mark Wiebe <[email protected]>
eherozhao
approved these changes
Nov 20, 2024
evanspearman-a
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
When testing conda environments that include the compilers provided by conda-forge, some of the activate/deactivate scripts reference environment variables that aren't set, and fail due to the
set -uoption.What was the solution? (How)
What is the impact of this change?
Customers using the example queue environment will have more reliable operation.
How was this change tested?
Deployed as a queue environment, and confirmed some cases that were failing now succeed.
Was this change documented?
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.