Flush writer after writing generated code #5919
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BufferedWriter is created in a try-with-resources, so it is always closed, but closing the writer does not actually flush the output stream; it just flushes the remaining data *buffered* in BufferedWriter to the stream: https://github.com/openjdk/jdk/blob/3c72c04de7a43d265dae7160fe53baaaa8ae6f73/src/java.base/share/classes/java/io/BufferedWriter.java#L311-L322 We still need to call BufferedWriter#flush() explicitly so that the output stream is flushed: https://github.com/openjdk/jdk/blob/3c72c04de7a43d265dae7160fe53baaaa8ae6f73/src/java.base/share/classes/java/io/BufferedWriter.java#L298-L308 This should hopefully fix issues where CodeWriter#validateFileContentMatches fails when comparing contents because the file on disk is truncated.
|
joviegas
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
BufferedWriter is created in a try-with-resources, so it is always closed, but closing the writer does not actually flush the output stream; it just flushes the remaining data buffered in BufferedWriter to the stream:
https://github.com/openjdk/jdk/blob/3c72c04de7a43d265dae7160fe53baaaa8ae6f73/src/java.base/share/classes/java/io/BufferedWriter.java#L311-L322
We still need to call BufferedWriter#flush() explicitly so that the output stream is flushed:
https://github.com/openjdk/jdk/blob/3c72c04de7a43d265dae7160fe53baaaa8ae6f73/src/java.base/share/classes/java/io/BufferedWriter.java#L298-L308
This should hopefully fix issues where
CodeWriter#validateFileContentMatches fails when comparing contents because the file on disk is truncated.
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License