SAK-47866 Changing the name of a published test associated to a grade…

…book item, and republishing it will cause the gradebook item not to be updated
axxter99 · Sep 22, 2022 · 085450e · 085450e
1 parent be2ed72
commit 085450e
Showing 1 changed file with 5 additions and 11 deletions.
diff --git a/...java/org/sakaiproject/tool/assessment/ui/listener/author/RepublishAssessmentListener.java b/...java/org/sakaiproject/tool/assessment/ui/listener/author/RepublishAssessmentListener.java
@@ -225,20 +225,14 @@ private void updateGB(PublishedAssessmentFacade assessment) {
     if (evaluation.getToGradeBook() != null	&& evaluation.getToGradeBook().equals(EvaluationModelIfc.TO_DEFAULT_GRADEBOOK.toString())) {
 
       String assessmentName = TextFormat.convertPlaintextToFormattedTextNoHighUnicode(assessment.getTitle().trim());
-      boolean gbItemExists = false;
-      try {
-        gbItemExists = gbsHelper.isAssignmentDefined(assessmentName, g);
-      } catch (Exception e1) {
-        log.info("assessment does not exist: {}", assessmentName);
-      }
-
+
       try {
-        if (!gbItemExists) {
-          log.debug("before gbsHelper.addToGradebook()");
-          gbsHelper.addToGradebook((PublishedAssessmentData) assessment.getData(), null, g);
-        } else {
+        try {
           log.debug("before gbsHelper.updateGradebook()");
           gbsHelper.updateGradebook((PublishedAssessmentData) assessment.getData(), g);
+        } catch (Exception ex) {
+          log.warn("Gradebook item does not exist for assessment {}, creating a new gradebook item", assessment.getAssessmentId());
+          gbsHelper.addToGradebook((PublishedAssessmentData) assessment.getData(), null, g);
         }
 
         // any score to copy over? get all the assessmentGradingData and copy over