Skip to content

Commit

Permalink
Fix name conflict for URLSessionTask
Browse files Browse the repository at this point in the history
Summary:
I'm on the fence about whether or not this is a breaking change. Technically it's a in a public header but it is also part of CoreKitBasics, a dependency of CoreKit and not a standalone library.

The question is, will this break existing implementations. I see how this is technically possible but also extremely unlikely. You would need to be trying to explicitly create a `FBSDKURLSessionTask` which is just a lightweight proxy wrapper around `NSURLSessionTask`.

It's also not listed in the public documentation so is by nature 'use at your own risk'.

Reviewed By: jingping2015

Differential Revision: D26429413

fbshipit-source-id: 472365cf3259f6c32d0b2b408fab63da4c9f74a3
  • Loading branch information
joesus authored and facebook-github-bot committed Feb 17, 2021
1 parent 115bbd1 commit 4a20f61
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Sources/FBSDKCoreKit_Basics/include/FBSDKURLSessionTask.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@
typedef void (^FBSDKURLSessionTaskBlock)(NSData *responseData,
NSURLResponse *response,
NSError *error)
NS_SWIFT_NAME(URLSessionTaskBlock);
NS_SWIFT_NAME(UrlSessionTaskBlock);

NS_SWIFT_NAME(URLSessionTask)
NS_SWIFT_NAME(UrlSessionTask)
@interface FBSDKURLSessionTask : NSObject

@property (nonatomic, strong) NSURLSessionTask *task;
Expand Down

0 comments on commit 4a20f61

Please sign in to comment.