Skip to content

Commit

Permalink
Move buckets.yaml into kettle.
Browse files Browse the repository at this point in the history
  • Loading branch information
Ryan Hitchman committed Jun 25, 2018
1 parent 77df355 commit c5d1eb0
Show file tree
Hide file tree
Showing 8 changed files with 11 additions and 13 deletions.
6 changes: 0 additions & 6 deletions BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,6 @@ filegroup(
visibility = ["//visibility:private"],
)

filegroup(
name = "buckets",
srcs = ["buckets.yaml"],
visibility = ["//:__subpackages__"],
)

workspace_binary(
name = "dep",
cmd = "//vendor/github.com/golang/dep/cmd/dep",
Expand Down
2 changes: 1 addition & 1 deletion docs/contributing-test-results.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ The process is as follows:
- Unfortunately this part is currently left as an exercise to the reader. We use
[bootstrap](/jenkins/bootstrap.py) to facilitate this and are in the midst of
rewriting it to better support external usage.
- Add the GCS bucket info to [buckets.yaml](/buckets.yaml) via a PR (use the
- Add the GCS bucket info to [buckets.yaml](/kettle/buckets.yaml) via a PR (use the
previously designated github handle for the `contact` field)
- Add jobs and dashboards to the [testgrid config](/testgrid/config.yaml) via
a PR (use the previously designated point of contact info in a comment next to
Expand Down
2 changes: 1 addition & 1 deletion docs/tests/node-e2e-ci.md
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ Official description of the individual files and their content is described by [
## Publishing test results in the TestGrid

To have the [TestGrid](https://k8s-testgrid.appspot.com/) consume the new build results, one needs to extend the TestGrid
configuration file at https://github.com/kubernetes/test-infra/blob/master/testgrid/config/config.yaml and a list of GCS buckets at https://github.com/kubernetes/test-infra/blob/master/buckets.yaml.
configuration file at https://github.com/kubernetes/test-infra/blob/master/testgrid/config/config.yaml and a list of GCS buckets at https://github.com/kubernetes/test-infra/blob/master/kettle/buckets.yaml.

The header of the file describes what needs to be done to add new build.
The current jobs have been added through https://github.com/kubernetes/test-infra/pull/5693 PR.
Expand Down
8 changes: 7 additions & 1 deletion kettle/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ py_test(
"model.py",
":package-srcs",
],
data = ["//:buckets"],
data = [":buckets"],
# idem
local = True,
deps = ["@yaml"],
Expand All @@ -92,3 +92,9 @@ filegroup(
tags = ["automanaged"],
visibility = ["//visibility:public"],
)

filegroup(
name = "buckets",
srcs = ["buckets.yaml"],
visibility = ["//:__subpackages__"],
)
2 changes: 0 additions & 2 deletions kettle/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,7 @@ get-cluster-credentials:
kubectl config use-context gke_k8s-gubernator_us-west1-b_g8r || gcloud container clusters get-credentials "$(CLUSTER)" --project="$(PROJECT)" --zone="$(ZONE)"

build:
cp ../buckets.yaml .
docker build -t $(IMG):$(TAG) .
rm buckets.yaml
docker tag $(IMG):$(TAG) $(IMG):latest
echo Built $(IMG):$(TAG) and tagged with $(IMG):latest ;

Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion kettle/make_json.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ def make_result(name, time, failure_text):

# pypy compatibility hack
BUCKETS = json.loads(subprocess.check_output(
['python2', '-c', 'import json,yaml; print json.dumps(yaml.load(open("../buckets.yaml")))'],
['python2', '-c', 'import json,yaml; print json.dumps(yaml.load(open("buckets.yaml")))'],
cwd=os.path.dirname(os.path.abspath(__file__))))


Expand Down
2 changes: 1 addition & 1 deletion kettle/update.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def call(cmd):


def main():
call('time python make_db.py --buckets ../buckets.yaml --junit --threads 32')
call('time python make_db.py --buckets buckets.yaml --junit --threads 32')

bq_cmd = 'bq load --source_format=NEWLINE_DELIMITED_JSON --max_bad_records=1000'
mj_cmd = 'pypy make_json.py'
Expand Down

0 comments on commit c5d1eb0

Please sign in to comment.