Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/Message) change SendAreaTriggerMessage for PSendSysMessage #40

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

pangolp
Copy link

@pangolp pangolp commented Oct 27, 2024

Changes Proposed:

  • When I made the previous pull request, to replace the %s and %u, some messages started to have problems to be displayed. I tried to modify them, but in the end, I thought it would be a good idea to send them in the chat, because there are addons that allow you to copy the text, however, if they are a SendAreaTriggerMessag, you cannot copy them.

Issues Addressed:

  • Closes

SOURCE:

Tests Performed:

  • Windows 10
  • Ingame

chat

How to Test the Changes:

  1. If you test the module without this change, some of the commands, when displaying the message, instead of seeing the values, will appear {}.
  2. After applying the change, the messages will no longer appear in the center of the screen, but in the chat. But in addition to that, the {} is no longer visible, instead, the value that should appear is displayed.

@Helias Helias merged commit 24be9fa into azerothcore:master Oct 27, 2024
1 check passed
@pangolp pangolp deleted the update branch October 27, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants