Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore. update module #41

Merged
merged 5 commits into from
Oct 31, 2024
Merged

chore. update module #41

merged 5 commits into from
Oct 31, 2024

Conversation

pangolp
Copy link

@pangolp pangolp commented Oct 31, 2024

Changes Proposed:

  • Add/modify information in README.md
  • Add .gitkeep files to empty directories
  • The configuration variables are renamed, prefixing them with: IndividualXp and adding/modifying information about them.
  • A new configuration variable called IndividualXp.AnnounceRatesOnLogin is added to show you the chosen and maximum rates set by the server when you log in. By default, it is enabled, but it can be disabled.
  • A struct is created to better organize the variables
  • I don't know why there were 2 classes of type PlayerScript, but 1 is removed, and the code is merged.
  • For several of the commands, if the experience was disabled, the message was executed anyway. So now, before executing the command, we check if the experience is active, and that way, we show the relevant message to the player.
  • The ads in the center of the screen are replaced by all ads in the chat, which allows, through the use of an addon, to copy the code and share it, in addition to greater visibility, since the ad on the screen is temporary and disappears.

Issues Addressed:

  • Closes

SOURCE:

Tests Performed:

  • Windows 10
  • In-game

How to Test the Changes:

  1. It is difficult to describe each step, because it depends a lot on the topics mentioned in the Changes Proposed section, but if you need more help in this regard, let me know and I will see how to complete this section.

rates

rates_in_chat

viewratesinlogin

WoWScrnShot_103124_095806

WoWScrnShot_103124_100859

WoWScrnShot_103124_100900

WoWScrnShot_103124_100933

WoWScrnShot_103124_100940

WoWScrnShot_103124_100948

@Helias Helias merged commit 199d202 into azerothcore:master Oct 31, 2024
1 check passed
@pangolp pangolp deleted the chore branch October 31, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants