Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding repetition parsing / validation #44

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

minjit
Copy link

@minjit minjit commented Jun 22, 2016

see title

fixes #6

@azoner
Copy link
Owner

azoner commented Jun 24, 2016

Nice work. I want to think a bit about the interface changes necessary for repeated values.

For backward compatibility, get_value() should return the element value for no repetitions and the formatted element list including the separator for repeats.

I'd like a get_values() method that returns a tuple(string). Elements with no repetitions would just have a single element tuple.

@azoner azoner self-assigned this Jun 24, 2016
@minjit
Copy link
Author

minjit commented Jun 24, 2016

Sure, I can take a look at that.

@minjit
Copy link
Author

minjit commented Jun 27, 2016

Get_value was already backwards compatible. Added the get_values_list method. Named it that way for clarity and it returns a list instead of a tuple because we're building a list anyway, but can convert it to a tuple at the end if you'd prefer.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 67.526% when pulling 3ed4711 on minjit:master into 2289ea8 on azoner:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle repeated elements
4 participants