[native messaging][chromeos] Remove unused policy handler

Also add comments explaining exclusion of tests and merge inclusion of removable_storage_provider_linux.cc on Linux and Lacros. Bug: 1293504 Change-Id: I79c797f8132f9c3452ca23ca829273411bf19d1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4277801 Reviewed-by: Devlin Cronin <[email protected]> Reviewed-by: Marc Treib <[email protected]> Auto-Submit: David Dorwin <[email protected]> Commit-Queue: Marc Treib <[email protected]> Cr-Commit-Position: refs/heads/main@{#1111483}
azx1573 · Mar 1, 2023 · 004351d · 004351d
1 parent d6e0a59
commit 004351d
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 4 deletions.
diff --git a/chrome/browser/extensions/BUILD.gn b/chrome/browser/extensions/BUILD.gn
@@ -246,8 +246,6 @@ static_library("extensions") {
     "api/messaging/native_message_port.h",
     "api/messaging/native_messaging_host_manifest.cc",
     "api/messaging/native_messaging_host_manifest.h",
-    "api/messaging/native_messaging_policy_handler.cc",
-    "api/messaging/native_messaging_policy_handler.h",
     "api/metrics_private/chrome_metrics_private_delegate.cc",
     "api/metrics_private/chrome_metrics_private_delegate.h",
     "api/networking_private/networking_private_ui_delegate_factory_impl.cc",
@@ -727,6 +725,14 @@ static_library("extensions") {
     "window_controller_list_observer.h",
   ]
 
+  # Chrome OS does not support Native Messaging policies.
+  if (!is_chromeos) {
+    sources += [
+      "api/messaging/native_messaging_policy_handler.cc",
+      "api/messaging/native_messaging_policy_handler.h",
+    ]
+  }
+
   configs += [
     "//build/config:precompiled_headers",
     "//build/config/compiler:wexit_time_destructors",
@@ -1237,7 +1243,6 @@ static_library("extensions") {
       "api/image_writer_private/image_writer_controller_lacros.cc",
       "api/image_writer_private/image_writer_controller_lacros.h",
       "api/image_writer_private/operation_nonchromeos.cc",
-      "api/image_writer_private/removable_storage_provider_linux.cc",
       "api/messaging/native_message_host_lacros.cc",
       "api/quick_unlock_private/quick_unlock_private_api_lacros.cc",
       "api/quick_unlock_private/quick_unlock_private_api_lacros.h",
@@ -1278,7 +1283,7 @@ static_library("extensions") {
     ]
   }
 
-  if (is_linux) {
+  if (is_linux || is_chromeos_lacros) {
     sources +=
         [ "api/image_writer_private/removable_storage_provider_linux.cc" ]
   }

diff --git a/chrome/browser/policy/BUILD.gn b/chrome/browser/policy/BUILD.gn
@@ -406,6 +406,8 @@ source_set("browser_tests") {
   if (!is_android && !is_chromeos) {
     sources += [
       "test/hardware_acceleration_mode_enabled_browsertest.cc",
+
+      # Chrome OS does not support this policy.
       "test/native_messaging_policy_browsertest.cc",
     ]
   }

diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn
@@ -8283,6 +8283,10 @@ test("unit_tests") {
 
       deps += [ "//components/enterprise:test_support" ]
     }
+
+    # The Chrome OS implementation of Native Messaging does not use the source
+    # files corresponding to these tests.
+    # Fuchsia does not support Native Messaging.
     if (!is_chromeos && !is_fuchsia) {
       sources += [
         "../browser/extensions/api/messaging/native_message_process_host_unittest.cc",