Skip to content

Commit

Permalink
[headless] Remove device screen configuration override in Mac tests
Browse files Browse the repository at this point in the history
Mac tests used to override device screen configuration because
the headless shell used underlying hardware screen configuration.

Since https://crrev.com/c/5637879 this workaround is not necessary,
so this CL removes it.

Bug: 347324963
Change-Id: I9bd3bbeb6b4e47b605ef30c61c24c7325e953835
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5640568
Commit-Queue: Peter Kvitek <[email protected]>
Reviewed-by: Andrey Kosyakov <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1318066}
  • Loading branch information
Peter Kvitek authored and Chromium LUCI CQ committed Jun 21, 2024
1 parent c1a5f4b commit 1a94c85
Showing 1 changed file with 0 additions and 13 deletions.
13 changes: 0 additions & 13 deletions headless/test/headless_devtooled_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -55,20 +55,7 @@ void HeadlessDevTooledBrowserTest::DevToolsTargetReady() {
devtools_client_.AttachToWebContents(
HeadlessWebContentsImpl::From(web_contents_)->web_contents());

#if BUILDFLAG(IS_MAC)
base::Value::Dict params;
params.Set("width", 0);
params.Set("height", 0);
params.Set("deviceScaleFactor", 1);
params.Set("mobile", false);
devtools_client_.SendCommand(
"Emulation.setDeviceMetricsOverride", std::move(params),
base::BindOnce([](HeadlessDevTooledBrowserTest* self,
base::Value::Dict params) { self->RunDevTooledTest(); },
base::Unretained(this)));
#else
RunDevTooledTest();
#endif
}

void HeadlessDevTooledBrowserTest::RenderProcessExited(
Expand Down

0 comments on commit 1a94c85

Please sign in to comment.