Skip to content

Commit

Permalink
[FedCM] Show active widget to take the focus when UI is displayed
Browse files Browse the repository at this point in the history
This patch reverted https://crrev.com/c/5499438. Starting a new patch
due to merge conflicts with an auto-revert.

Bug: 41482141, 339481295
Change-Id: I504489ec22a58521c20561f7ac5c4513b6a195d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5578261
Reviewed-by: Zachary Tan <[email protected]>
Commit-Queue: Yi Gu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1307125}
  • Loading branch information
yi-gu authored and Chromium LUCI CQ committed May 28, 2024
1 parent 57e1c5c commit 3184b5f
Showing 1 changed file with 3 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -74,15 +74,9 @@ void FedCmAccountSelectionView::ShowDialogWidget() {
// one to focus on the content area and one to focus on the clickable
// 2. user typing will be interrupted because the widget that's not
// gated by user gesture would take the focus
// However, from accessibility's perspective, when the widget is
// displayed, there would be announcement with it and it would be better
// to focus on the widget such that the user could have more context and
// interact with it easily.
if (accessibility_state_utils::IsScreenReaderEnabled()) {
GetDialogWidget()->Show();
return;
}
GetDialogWidget()->ShowInactive();
// TODO(crbug.com/41482141): figure out how to address this issue without
// causing additional problems such as obscuring other browser UIs.
GetDialogWidget()->Show();
}

bool FedCmAccountSelectionView::Show(
Expand Down

0 comments on commit 3184b5f

Please sign in to comment.