Skip to content

Commit

Permalink
Clean up miscategorized PlatformBrowserTests (Android)
Browse files Browse the repository at this point in the history
PlatformBrowserTest is a utility designed to run tests on both
Android and Desktop platforms and, under the hood, is aliased to either
InProcessBrowserTest or AndroidBrowserTest. However, some of the classes
that are written with it are not intended to run on both sets of
platforms.

This CL cleans up instances of inheriting from PlatformBrowserTest where
the test only runs on Android to instead use AndroidBrowserTest
directly.

Bug: 361002665
Change-Id: Ib7d77418859b0f15f6e6909974e5690f5e4a95fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5804981
Auto-Submit: Devlin Cronin <[email protected]>
Commit-Queue: Yaron Friedman <[email protected]>
Reviewed-by: Yaron Friedman <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1344971}
  • Loading branch information
rdcronin authored and Chromium LUCI CQ committed Aug 21, 2024
1 parent 5d29bc2 commit 56a655d
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
#include "base/memory/scoped_refptr.h"
#include "base/run_loop.h"
#include "base/test/scoped_feature_list.h"
#include "chrome/test/base/android/android_browser_test.h"
#include "chrome/test/base/chrome_test_utils.h"
#include "components/webapps/browser/android/shortcut_info.h"
#include "components/webapps/browser/android/webapp_icon.h"
Expand All @@ -30,7 +31,7 @@
#include "url/origin.h"

// Browser tests for WebApkIconHasher.
class WebApkIconHasherBrowserTest : public PlatformBrowserTest {
class WebApkIconHasherBrowserTest : public AndroidBrowserTest {
public:
WebApkIconHasherBrowserTest()
: http_server_(net::EmbeddedTestServer::TYPE_HTTP) {
Expand Down

0 comments on commit 56a655d

Please sign in to comment.