Replace if () NOTREACHED() with CHECK() in ash/public/cpp/external_ar…

…c/message_center

Replace simple cases of if (foo) NOTREACHED(); and if (!bar)
NOTREACHED() with CHECK(!foo); and CHECK(bar) in
ash/public/cpp/external_arc/message_center.

This aligns with current guidance:
https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/checks.md#:~:text=Use%20CHECK(bar)%3B%20instead

Most changes were automated with regular expression substitutions.

This CL was uploaded by git cl split.

[email protected]

Change-Id: Ic809949f8a2683d51b7cdccc16fe48fa7f226f97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5826744
Auto-Submit: Adam Rice <[email protected]>
Commit-Queue: Toshiki Kikuchi <[email protected]>
Commit-Queue: Adam Rice <[email protected]>
Reviewed-by: Toshiki Kikuchi <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1349738}

ash/public/cpp/external_arc/message_center/arc_notification_surface_manager_impl.cc

@@ -8,6 +8,7 @@
 #include <utility>
 
 #include "ash/public/cpp/external_arc/message_center/arc_notification_surface_impl.h"
+#include "base/check.h"
 #include "components/exo/notification_surface.h"
 
 namespace ash {
@@ -55,9 +56,7 @@ void ArcNotificationSurfaceManagerImpl::AddSurface(
       std::pair<std::string, std::unique_ptr<ArcNotificationSurfaceImpl>>(
           surface->notification_key(),
           std::make_unique<ArcNotificationSurfaceImpl>(surface)));
-  if (!result.second) {
-    NOTREACHED();
-  }
+  CHECK(result.second);
 
   for (auto& observer : observers_)
     observer.OnNotificationSurfaceAdded(result.first->second.get());