Allow scrolling down specs list.

Screencast: http://shortn/_UnukgvXMOR Bug: 349848189 Change-Id: I47095c6ca4263472c9b7508f9306c2d036fe1163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5673152 Auto-Submit: Gloria Fang <[email protected]> Reviewed-by: Matthew Jones <[email protected]> Commit-Queue: Gloria Fang <[email protected]> Reviewed-by: John Lee <[email protected]> Cr-Commit-Position: refs/heads/main@{#1326358}
azx1573 · Jul 11, 2024 · 92e0226 · 92e0226
1 parent 91e1054
commit 92e0226
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/chrome/browser/resources/history/app.ts b/chrome/browser/resources/history/app.ts
@@ -447,10 +447,11 @@ export class HistoryAppElement extends HistoryAppElementBase {
   override _scrollHandler() {
     if (this.scrollTarget) {
       // When the tabs are visible, show the toolbar shadow for the synced
-      // devices page only.
+      // devices page or product specifications page.
       this.toolbarShadow_ = this.scrollTarget.scrollTop !== 0 &&
           (!this.showHistoryClusters_ ||
-           this.syncedTabsSelected_(this.selectedPage_!));
+           this.syncedTabsSelected_(this.selectedPage_!) ||
+           this.selectedPage_ === Page.PRODUCT_SPECIFICATIONS_LISTS);
     }
   }
 

diff --git a/chrome/browser/resources/history/product_specifications_item.html b/chrome/browser/resources/history/product_specifications_item.html
@@ -23,7 +23,7 @@
   }
 </style>
 
-<div role="row" on-pointerdown="onRowPointerDown_">
+<div role="row" on-mousedown="onRowPointerDown_">
   <div id="item-container">
     <cr-checkbox id="checkbox" checked="{{checked}}"
         on-pointerdown="onCheckboxPointerDown_"

diff --git a/chrome/browser/resources/history/product_specifications_lists.html b/chrome/browser/resources/history/product_specifications_lists.html
@@ -1,4 +1,9 @@
 <style include="shared-style cr-shared-style">
+  :host {
+    display: block;
+    overflow: auto;
+  }
+
   .history-cards {
     margin-block-start: var(--first-card-padding-top);
   }

diff --git a/chrome/browser/resources/history/product_specifications_lists.ts b/chrome/browser/resources/history/product_specifications_lists.ts
@@ -60,7 +60,6 @@ export class ProductSpecificationsListsElement extends PolymerElement {
   selectedItems: Set<string> = new Set();
   private pendingDelete_: boolean = false;
   private lastSelectedIndex_: number|undefined = undefined;
-
   private shoppingApi_: BrowserProxy = BrowserProxyImpl.getInstance();
   private allItems_: ProductSpecificationsSet[] = [];
   private focusGrid_: FocusGrid|null = null;