Treat raw_span like span for the complex ctors warning.

[email protected] Bug: 363264995 Change-Id: I0ddf8b6599eb0a351e82a13a05c509d16a2cb39c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5855299 Reviewed-by: Hans Wennborg <[email protected]> Auto-Submit: danakj <[email protected]> Commit-Queue: Hans Wennborg <[email protected]> Cr-Commit-Position: refs/heads/main@{#1354410}
azx1573 · Sep 12, 2024 · 96fb39a · 96fb39a
1 parent 074d04a
commit 96fb39a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/build/config/clang/BUILD.gn b/build/config/clang/BUILD.gn
@@ -84,22 +84,15 @@ config("find_bad_constructs") {
       "-Xclang",
       "raw-ref-template-as-trivial-member",
 
-      # TODO(danakj): Enable this.
-      # "-Xclang",
-      # "-plugin-arg-find-bad-constructs",
-      # "-Xclang",
-      # "raw-span-template-as-trivial-member",
-
       "-Xclang",
       "-plugin-arg-find-bad-constructs",
       "-Xclang",
-      "check-stack-allocated",
+      "raw-span-template-as-trivial-member",
 
-      # TODO(danakj): Delete this after the next clang roll.
       "-Xclang",
       "-plugin-arg-find-bad-constructs",
       "-Xclang",
-      "check-allow-auto-typedefs-better-nested",
+      "check-stack-allocated",
     ]
 
     if (is_linux || is_chromeos || is_android || is_fuchsia) {

diff --git a/tools/clang/plugins/FindBadConstructsAction.cpp b/tools/clang/plugins/FindBadConstructsAction.cpp
@@ -60,8 +60,6 @@ bool FindBadConstructsAction::ParseArgs(const CompilerInstance& instance,
     if (arg.starts_with(kExcludeFieldsArgPrefix)) {
       options_.exclude_fields_file =
           arg.substr(strlen(kExcludeFieldsArgPrefix)).str();
-    } else if (arg == "check-allow-auto-typedefs-better-nested") {
-      // This flag to be removed once clang rolls.
     } else if (arg == "check-base-classes") {
       // TODO(rsleevi): Remove this once http://crbug.com/123295 is fixed.
       options_.check_base_classes = true;