rollback vega render PR streamlit#497 (streamlit#667)

b-xiang · Nov 11, 2019 · 2d11914 · 2d11914
1 parent b29da49
commit 2d11914
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 49 deletions.
diff --git a/e2e/scripts/vega_update.py b/e2e/scripts/vega_update.py
diff --git a/e2e/specs/vega_update.spec.ts b/e2e/specs/vega_update.spec.ts
diff --git a/frontend/src/components/elements/VegaLiteChart/VegaLiteChart.tsx b/frontend/src/components/elements/VegaLiteChart/VegaLiteChart.tsx
@@ -202,7 +202,7 @@ class VegaLiteChart extends React.PureComponent<PropsWithHeight, State> {
       }
     }
 
-    this.vegaView.runAsync()
+    this.vegaView.resize().runAsync()
   }
 
   /**
@@ -330,7 +330,11 @@ class VegaLiteChart extends React.PureComponent<PropsWithHeight, State> {
 
     this.vegaView = view
 
-    await view.resize().runAsync()
+    await view.runAsync()
+
+    // Fix bug where the "..." menu button overlaps with charts where width is
+    // set to -1 on first load.
+    this.vegaView.resize().runAsync()
   }
 }