Skip to content

Commit

Permalink
SimplifyIV comments and dead argument cleanup.
Browse files Browse the repository at this point in the history
Remove crufty comments. IVUsers hasn't been used here for a long time.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@237586 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
atrick committed May 18, 2015
1 parent ccafe05 commit 688ae33
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
9 changes: 4 additions & 5 deletions lib/Transforms/Scalar/IndVarSimplify.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -622,9 +622,8 @@ void IndVarSimplify::RewriteLoopExitValues(Loop *L, SCEVExpander &Rewriter) {
}
}

// If we were unable to completely replace the PHI node, clone the PHI
// and delete the original one. This lets IVUsers and any other maps
// purge the original user from their records.
// If we were unable to completely replace the PHI node, clone the PHI and
// delete the original one. This purges the original phi.
if (!LCSSASafePhiForRAUW) {
PHINode *NewPN = cast<PHINode>(PN->clone());
NewPN->takeName(PN);
Expand Down Expand Up @@ -915,8 +914,8 @@ const SCEVAddRecExpr* WidenIV::GetExtendedOperandRecurrence(NarrowIVDefUse DU) {
return AddRec;
}

/// GetWideRecurrence - Is this instruction potentially interesting from
/// IVUsers' perspective after widening it's type? In other words, can the
/// GetWideRecurrence - Is this instruction potentially interesting for further
/// simplification after widening it's type? In other words, can the
/// extend be safely hoisted out of the loop with SCEV reducing the value to a
/// recurrence on the same loop. If so, return the sign or zero extended
/// recurrence. Otherwise return NULL.
Expand Down
3 changes: 1 addition & 2 deletions lib/Transforms/Utils/SimplifyIndVar.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
#include "llvm/ADT/STLExtras.h"
#include "llvm/ADT/SmallVector.h"
#include "llvm/ADT/Statistic.h"
#include "llvm/Analysis/IVUsers.h"
#include "llvm/Analysis/LoopInfo.h"
#include "llvm/Analysis/LoopPass.h"
#include "llvm/Analysis/ScalarEvolutionExpressions.h"
Expand Down Expand Up @@ -55,7 +54,7 @@ namespace {

public:
SimplifyIndvar(Loop *Loop, ScalarEvolution *SE, LoopInfo *LI,
SmallVectorImpl<WeakVH> &Dead, IVUsers *IVU = nullptr)
SmallVectorImpl<WeakVH> &Dead)
: L(Loop), LI(LI), SE(SE), DeadInsts(Dead), Changed(false) {
assert(LI && "IV simplification requires LoopInfo");
}
Expand Down

0 comments on commit 688ae33

Please sign in to comment.