Ripping out Rave

bac-forks · Oct 20, 2022 · 0f69c2f · 0f69c2f
1 parent 6d51b99
commit 0f69c2f
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 55 deletions.
diff --git a/android/gradle/dependencies.gradle b/android/gradle/dependencies.gradle
@@ -35,7 +35,6 @@ def versions = [
     ktfmt: '0.23',
     ktlint: '0.41.0',
     motif: '0.3.4',
-    rave: "2.0.0",
     robolectric: "4.4",
     spotless: '5.11.0'
 ]
@@ -51,7 +50,6 @@ def apt = [
     javaxInject: "javax.inject:javax.inject:1",
     autoValue: "com.google.auto.value:auto-value:1.7",
     autoValueAnnotations: "com.google.auto.value:auto-value-annotations:1.7",
-    raveCompiler: "com.uber:rave-compiler:${versions.rave}",
     errorProneAnnotations: "com.google.errorprone:error_prone_annotations:${versions.errorProne}",
 ]
 
@@ -145,7 +143,6 @@ def uber = [
     autodisposeErrorProne: "com.uber.autodispose:autodispose-error-prone:${versions.autodispose}",
     motif: "com.uber.motif:motif:${versions.motif}",
     motifCompiler: "com.uber.motif:motif-compiler:${versions.motif}",
-    rave: "com.uber:rave:${versions.rave}",
 ]
 
 ext.deps = [

diff --git a/android/tutorials/tutorial4/build.gradle b/android/tutorials/tutorial4/build.gradle
@@ -48,7 +48,6 @@ android {
 
 dependencies {
     annotationProcessor deps.apt.autoValue
-    annotationProcessor deps.apt.raveCompiler
     annotationProcessor deps.apt.daggerCompiler
     annotationProcessor project(":libraries:rib-compiler-test")
     implementation project(":libraries:rib-android")
@@ -57,7 +56,6 @@ dependencies {
     implementation deps.androidx.appcompat
     implementation deps.external.dagger
     implementation deps.external.rxbinding
-    implementation deps.uber.rave
     implementation deps.androidx.percent
     implementation deps.external.guavaAndroid
     compileOnly deps.apt.javax

diff --git a/android/tutorials/tutorial4/src/main/java/com/uber/rib/RootActivity.java b/android/tutorials/tutorial4/src/main/java/com/uber/rib/RootActivity.java
@@ -17,13 +17,10 @@
 
 import android.content.Intent;
 import android.os.Bundle;
-import android.util.Log;
 import android.view.ViewGroup;
 import androidx.annotation.Nullable;
 import com.google.common.base.Optional;
 import com.uber.autodispose.AutoDispose;
-import com.uber.rave.Rave;
-import com.uber.rave.RaveException;
 import com.uber.rib.core.RibActivity;
 import com.uber.rib.core.ViewRouter;
 import com.uber.rib.root.RootBuilder;
@@ -58,20 +55,15 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {
   private void handleDeepLink(Intent intent) {
     RootWorkflow<RootReturnValue, ?> rootWorkflow = new WorkflowFactory().getWorkflow(intent);
     if (rootWorkflow != null) {
-      try {
-        Rave.getInstance().validate(rootWorkflow.getDeepLinkModel());
 
-        rootWorkflow
-            .createSingle(rootInteractor)
-            .as(AutoDispose.<Optional<RootReturnValue>>autoDisposable(this))
-            .subscribe(
-                new Consumer<Optional<?>>() {
-                  @Override
-                  public void accept(Optional<?> optional) throws Exception {}
-                });
-      } catch (RaveException exception) {
-        Log.e("RootActivity", "Invalid deep link model received.", exception);
-      }
+      rootWorkflow
+          .createSingle(rootInteractor)
+          .as(AutoDispose.<Optional<RootReturnValue>>autoDisposable(this))
+          .subscribe(
+              new Consumer<Optional<?>>() {
+                @Override
+                public void accept(Optional<?> optional) throws Exception {}
+              });
     }
   }
 

diff --git a/...utorials/tutorial4/src/main/java/com/uber/rib/root/TrainingSessionsValidationFactory.java b/...utorials/tutorial4/src/main/java/com/uber/rib/root/TrainingSessionsValidationFactory.java