Filter out connection failures (MystenLabs#1896)

Filter out connection failures in shared object tests
bagnetov · May 11, 2022 · 541fdce · 541fdce
1 parent f766470
commit 541fdce
Show file tree

Hide file tree

Showing 2 changed files with 48 additions and 48 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/sui/tests/shared_objects_tests.rs b/sui/tests/shared_objects_tests.rs
@@ -4,7 +4,7 @@ use sui::config::AuthorityInfo;
 use sui_core::authority_client::{AuthorityAPI, NetworkAuthorityClient};
 use sui_types::{
     base_types::ObjectRef,
-    error::SuiResult,
+    error::{SuiError, SuiResult},
     messages::{
         CallArg, ConfirmationTransaction, ConsensusTransaction, ExecutionStatus, Transaction,
         TransactionInfoResponse,
@@ -64,13 +64,15 @@ async fn submit_shared_object_transaction(
             })
             .collect();
 
-        let mut replies = Vec::new();
-        for result in futures::future::join_all(futures).await {
-            replies.push(Some(result))
-        }
-        if replies.iter().any(|x| x.is_some()) {
+        let replies: Vec<_> = futures::future::join_all(futures)
+            .await
+            .into_iter()
             // Remove all `ConsensusConnectionBroken` replies.
-            break replies.into_iter().flatten().collect();
+            .filter(|result| !matches!(result, Err(SuiError::ConsensusConnectionBroken(..))))
+            .collect();
+
+        if !replies.is_empty() {
+            break replies;
         }
     }
 }